chore: capture all the envelopes - #2812
Draft
bitsandfoxes wants to merge 3 commits into
Draft
Conversation
bitsandfoxes
force-pushed
the
chore/fetch-envelopes
branch
from
August 13, 2026 16:33
d1a59a6 to
83d5600
Compare
Comment on lines
+76
to
+77
| - name: Start envelope capture server | ||
| run: ./test/Scripts.Integration.Test/start-capture-server.ps1 -Platform "android-${{ env.UNITY_VERSION }}" -Output "test/IntegrationTest/symbols/android-${{ env.UNITY_VERSION }}" |
There was a problem hiding this comment.
SENTRY_AUTH_TOKEN written into uploaded Android capture artifacts
On CI runs with the Sentry secret available, Android's captured upload-proguard request metadata includes the Bearer token and is uploaded in the symbols-android-* artifact, allowing artifact readers to recover the credential. Redact authorization headers before writing capture metadata or exclude the metadata files from the artifact.
Evidence
.github/workflows/test-build-android.ymlstartsenvelope-capture-server.pywith output undertest/IntegrationTest/symbols/android-${{ env.UNITY_VERSION }}and always uploadstest/IntegrationTest/symbols/as an artifact.CliConfigurationreadsSENTRY_AUTH_TOKENand setscliOptions.Auth;SentryCli.CreateSentryPropertieswrites that value asauth.token, which sentry-cli uses for build-time uploads.test/Scripts.Integration.Test/Editor/Builder.csenables Android debug and release minification, whileDebugSymbolUploadregistersupload-proguardfor minified builds.- The capture server only special-cases
/chunk-upload/and/assemble/; the proguard POST reaches the generic handler, which writesdict(self.headers)into.meta.jsonandindex.jsonlbeneath the artifact output.
Also found at 1 additional location
.github/workflows/ci.yml:379-382
Identified by Warden · security-review · 4BH-LDB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do not merge. this is just harvesting envelopes.
#skip-changelog