Skip to content

chore: capture all the envelopes - #2812

Draft
bitsandfoxes wants to merge 3 commits into
mainfrom
chore/fetch-envelopes
Draft

chore: capture all the envelopes#2812
bitsandfoxes wants to merge 3 commits into
mainfrom
chore/fetch-envelopes

Conversation

@bitsandfoxes

@bitsandfoxes bitsandfoxes commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

do not merge. this is just harvesting envelopes.

#skip-changelog

@bitsandfoxes
bitsandfoxes force-pushed the chore/fetch-envelopes branch from d1a59a6 to 83d5600 Compare August 13, 2026 16:33
Comment on lines +76 to +77
- name: Start envelope capture server
run: ./test/Scripts.Integration.Test/start-capture-server.ps1 -Platform "android-${{ env.UNITY_VERSION }}" -Output "test/IntegrationTest/symbols/android-${{ env.UNITY_VERSION }}"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SENTRY_AUTH_TOKEN written into uploaded Android capture artifacts

On CI runs with the Sentry secret available, Android's captured upload-proguard request metadata includes the Bearer token and is uploaded in the symbols-android-* artifact, allowing artifact readers to recover the credential. Redact authorization headers before writing capture metadata or exclude the metadata files from the artifact.

Evidence
  • .github/workflows/test-build-android.yml starts envelope-capture-server.py with output under test/IntegrationTest/symbols/android-${{ env.UNITY_VERSION }} and always uploads test/IntegrationTest/symbols/ as an artifact.
  • CliConfiguration reads SENTRY_AUTH_TOKEN and sets cliOptions.Auth; SentryCli.CreateSentryProperties writes that value as auth.token, which sentry-cli uses for build-time uploads.
  • test/Scripts.Integration.Test/Editor/Builder.cs enables Android debug and release minification, while DebugSymbolUpload registers upload-proguard for minified builds.
  • The capture server only special-cases /chunk-upload/ and /assemble/; the proguard POST reaches the generic handler, which writes dict(self.headers) into .meta.json and index.jsonl beneath the artifact output.
Also found at 1 additional location
  • .github/workflows/ci.yml:379-382

Identified by Warden · security-review · 4BH-LDB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant