Skip to content

test(huggingface_hub): Only check relevant data with ApproxDict - #7434

Merged
alexander-alderman-webb merged 1 commit into
masterfrom
webb/huggingface-hub/approx-dict
Sep 9, 2026
Merged

test(huggingface_hub): Only check relevant data with ApproxDict#7434
alexander-alderman-webb merged 1 commit into
masterfrom
webb/huggingface-hub/approx-dict

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Contributor

Description

Since child spans and segment spans have different attributes, it's useful to only check attributes the integration adds.

Issues

Reminders

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

130694 passed | ⏭️ 7131 skipped | Total: 137825 | Pass Rate: 94.83% | Execution Time: 477m 6s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -102
Passed Tests 📉 -101
Failed Tests 📉 -1
Skipped Tests

➖ Removed Tests (1)

View removed tests
  • test_cache_spans_templatetag[True]
    • File: tests.integrations.django.test_cache_module

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2521 uncovered lines.
❌ Project coverage is 90.22%. Comparing base (e81c7b8) to head (60d37b6).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.24%    90.22%    -0.02%
==========================================
  Files          193       193         —
  Lines        25774     25772        -2
  Branches      9514      9514         —
==========================================
+ Hits         23259     23251        -8
- Misses        2515      2521        +6
- Partials      1433      1434        +1

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review September 8, 2026 14:56
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 8, 2026 14:56

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@alexander-alderman-webb
alexander-alderman-webb removed this pull request from stack #7437 September 9, 2026 07:18
@alexander-alderman-webb
alexander-alderman-webb merged commit 053059e into master Sep 9, 2026
309 of 312 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/huggingface-hub/approx-dict branch September 9, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants