Skip to content

chore(asgi): Remove transaction-based tracing - #7433

Merged
sentrivana merged 12 commits into
major/3.0from
ivana/major/remove-transactions-asgi
Sep 9, 2026
Merged

chore(asgi): Remove transaction-based tracing#7433
sentrivana merged 12 commits into
major/3.0from
ivana/major/remove-transactions-asgi

Conversation

@sentrivana

@sentrivana sentrivana commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

The removed ...request_data... tests all have a ...request_attributes... span streaming counterpart.

The removed test_asgi_transaction_request_body_data_collection is covered by test_asgi_request_body_data_collection.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

71534 passed | ❌ 1 failed | ⏭️ 3370 skipped | Total: 74905 | Pass Rate: 95.5% | Execution Time: 220m 36s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -64131
Passed Tests 📉 -60371
Failed Tests 📈 +1
Skipped Tests 📉 -3761

➕ New Tests (1)

View new tests
  • test_cache_spans_item_size
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

❌ Failed Tests

test_cache_spans_item_size

File: tests.integrations.django.test_cache_module
Suite: py3.12-django-v4.2.30
Error: tests/integrations/django/test_cache_module.py:526: in test_cache_spans_item_size assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:526: in test_cache_spans_item_size
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

❌ Patch coverage is 79.17%. Project has 2288 uncovered lines.
❌ Project coverage is 89.99%. Comparing base (868323a) to head (d750b3a).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/asgi.py 79.17% ⚠️ 5 Missing and 1 partials
Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.21%    89.99%    -0.22%
==========================================
  Files          193       185        -8
  Lines        25788     22847     -2941
  Branches      9530      8334     -1196
==========================================
+ Hits         23261     20559     -2702
- Misses        2527      2288      -239
- Partials      1432      1335       -97

Generated by Codecov Action

@sentrivana
sentrivana marked this pull request as ready for review September 9, 2026 11:17
@sentrivana
sentrivana requested a review from a team as a code owner September 9, 2026 11:17
@sentrivana
sentrivana merged commit d6ffc8a into major/3.0 Sep 9, 2026
147 of 149 checks passed
@sentrivana
sentrivana deleted the ivana/major/remove-transactions-asgi branch September 9, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants