Skip to content

chore(aiomysql): Remove transaction-based tracing #7191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentrivana wants to merge 2 commits into
base: major/3.0
Choose a base branch
from
+232 −583
Open

chore(aiomysql): Remove transaction-based tracing #7191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eca2533
chore(aiomysql): Remove transaction-based-tracing
sentrivana Aug 13, 2026
a1f5568
.
sentrivana Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 12 additions & 33 deletions sentry_sdk/integrations/aiomysql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from sentry_sdk.traces import StreamedSpan
from sentry_sdk.tracing_utils import (
add_query_source,
has_span_streaming_enabled,
record_sql_queries,
)
from sentry_sdk.utils import (
Expand Down Expand Up @@ -187,42 +186,22 @@ async def _inner(self: "Connection") -> T:
if client.get_integration(AioMySQLIntegration) is None:
return await f(self)

if has_span_streaming_enabled(client.options):
breadcrumb_data = _get_connect_data(self, use_streaming_keys=True)
breadcrumb_data = _get_connect_data(self, use_streaming_keys=True)

with capture_internal_exceptions():
sentry_sdk.add_breadcrumb(
message="connect", category="query", data=breadcrumb_data
)

if sentry_sdk.traces.get_current_span() is None:
return await f(self)

span_attributes: dict[str, Any] = {
"sentry.op": OP.DB,
"sentry.origin": AioMySQLIntegration.origin,
} | breadcrumb_data

Comment thread
sentrivana marked this conversation as resolved.
with sentry_sdk.traces.start_span(
name="connect", attributes=span_attributes
):
return await f(self)
with capture_internal_exceptions():
sentry_sdk.add_breadcrumb(
message="connect", category="query", data=breadcrumb_data
)

connect_data = _get_connect_data(self)
if sentry_sdk.traces.get_current_span() is None:
return await f(self)

with sentry_sdk.start_span(
op=OP.DB,
name="connect",
origin=AioMySQLIntegration.origin,
) as span:
_set_db_data(span, self)
span_attributes: dict[str, Any] = {
"sentry.op": OP.DB,
"sentry.origin": AioMySQLIntegration.origin,
} | breadcrumb_data

with capture_internal_exceptions():
sentry_sdk.add_breadcrumb(
message="connect",
category="query",
data=connect_data,
)
with sentry_sdk.traces.start_span(name="connect", attributes=span_attributes):
return await f(self)

return _inner
Expand Down
Loading
Loading