Skip to content

test(attachments): cleanup scope flush assertions - #1947

Merged
JoshuaMoelans merged 1 commit into
masterfrom
joshua/fix/att_test
Aug 4, 2026
Merged

test(attachments): cleanup scope flush assertions#1947
JoshuaMoelans merged 1 commit into
masterfrom
joshua/fix/att_test

Conversation

@JoshuaMoelans

@JoshuaMoelans JoshuaMoelans commented Aug 4, 2026

Copy link
Copy Markdown
Member

follow-up to #1934 , more robustly fetching the keys using get() and folded the assertion into the function that we wait for. No longer should fail on unflushed content_type as in https://github.com/getsentry/sentry-native/actions/runs/30884798825/job/91913533861#step:31:63880

#skip-changelog

@JoshuaMoelans JoshuaMoelans changed the title test(attachments): add more robust manifest assertions test(attachments): cleanup scope flush assertions Aug 4, 2026
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.87%. Comparing base (f537fa2) to head (98e61c0).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1947      +/-   ##
==========================================
- Coverage   75.90%   75.87%   -0.04%     
==========================================
  Files          93       93              
  Lines       22183    22183              
  Branches     3951     3951              
==========================================
- Hits        16838    16831       -7     
- Misses       4459     4467       +8     
+ Partials      886      885       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoshuaMoelans
JoshuaMoelans marked this pull request as ready for review August 4, 2026 11:31

@jpnurmi jpnurmi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@JoshuaMoelans
JoshuaMoelans merged commit a2fc552 into master Aug 4, 2026
68 checks passed
@JoshuaMoelans
JoshuaMoelans deleted the joshua/fix/att_test branch August 4, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants