Skip to content

feat: added app_hang_pause - #1928

Merged
bitsandfoxes merged 10 commits into
masterfrom
feat/app-hang-pause
Jul 30, 2026
Merged

feat: added app_hang_pause#1928
bitsandfoxes merged 10 commits into
masterfrom
feat/app-hang-pause

Conversation

@bitsandfoxes

@bitsandfoxes bitsandfoxes commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Huge footgun for anything that can be put on the background. Like a game.

Calling pause pauses the app hang detection. The next heartbeat resumes the detection again.

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b6d804f

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ce9f30a. Configure here.

Comment thread src/sentry_app_hang_latch.c Outdated
@bitsandfoxes
bitsandfoxes requested a review from a team July 29, 2026 16:08
@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.77%. Comparing base (ee9ac8c) to head (b6d804f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1928      +/-   ##
==========================================
+ Coverage   75.76%   75.77%   +0.01%     
==========================================
  Files          93       93              
  Lines       22104    22125      +21     
  Branches     3935     3939       +4     
==========================================
+ Hits        16746    16765      +19     
- Misses       4473     4477       +4     
+ Partials      885      883       -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoshuaMoelans JoshuaMoelans left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few nits/comments/questions, main ones are about resetting the last timestamp captured to 0 on pause & a full test that actually invokes the worker which checks the paused state

Comment thread src/sentry_app_hang_monitor.c Outdated
Comment thread CHANGELOG.md Outdated
Comment thread include/sentry.h
Comment thread tests/unit/test_app_hang.c
Comment thread src/sentry_app_hang_latch.c
bitsandfoxes and others added 4 commits July 30, 2026 12:24
Co-authored-by: JoshuaMoelans <60878493+JoshuaMoelans@users.noreply.github.com>
Co-authored-by: JoshuaMoelans <60878493+JoshuaMoelans@users.noreply.github.com>
Comment thread src/sentry_app_hang_latch.c
@bitsandfoxes
bitsandfoxes merged commit e3c769f into master Jul 30, 2026
66 checks passed
@bitsandfoxes
bitsandfoxes deleted the feat/app-hang-pause branch July 30, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants