fix(github): add write credential correlation telemetry - #1654
Open
sentry-junior[bot] wants to merge 3 commits into
Open
fix(github): add write credential correlation telemetry#1654sentry-junior[bot] wants to merge 3 commits into
sentry-junior[bot] wants to merge 3 commits into
Conversation
Log a safe token fingerprint from mint through lease cache and outbound injection, and keep mint permissions/repositories on the issue path so intermittent git-receive-pack 403s can be correlated. Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Use HMAC domain fingerprints for credential correlation and keep plugin.ts under the 1000-line limit.
dcramer
marked this pull request as ready for review
August 22, 2026 05:36
Keep only a mint fingerprint and the same fingerprint on upstream auth rejection. Drop the extra lease/injection events and mint-envelope logging. Co-Authored-By: David Cramer <david@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intermittent GitHub write 403s after a successful installation-token mint are hard to diagnose because Junior does not correlate the token across mint and the rejected hop.
This keeps the change small:
sandbox.egress.upstream_auth.rejectedNo retry and no other behavior change. After deploy, the next snuba push flake should show whether the rejected hop used the same token that was just minted.
Requested by David Cramer.
--
View Junior Session [Sentry]