Cicd combined by aviv1ron1 · Pull Request #95 · generative-computing/granite-switch

aviv1ron1 · 2026-07-09T12:38:40Z

No description provided.

Signed-off-by: aviv ron <rona@il.ibm.com>

codecov-commenter · 2026-07-09T18:32:38Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

Signed-off-by: aviv ron <rona@il.ibm.com>

Ruff loads its config from pyproject.toml, so a malformed pyproject.toml makes ruff abort with a parser error instead of the clean check-toml message. Running check-toml/check-yaml first (with fail_fast) ensures syntax errors are reported by the dedicated validator, consistently between local commits and CI's --all-files run. Signed-off-by: aviv ron <rona@il.ibm.com>

check-added-large-files only inspects staged additions, so on CI's clean checkout (nothing staged) it was a no-op. --enforce-all makes it check all files under pre-commit run --all-files. uv.lock (~2.3 MB) is excluded as an intentionally large lockfile. Signed-off-by: aviv ron <rona@il.ibm.com>

check-merge-conflict returns early unless a merge is in progress, so on CI's clean checkout it was a no-op. --assume-in-merge makes it always scan, letting pre-commit run --all-files catch committed conflict markers. Signed-off-by: aviv ron <rona@il.ibm.com>

…hooks Signed-off-by: aviv ron <rona@il.ibm.com>

Signed-off-by: aviv ron <rona@il.ibm.com>

uv lock resolves fine on macOS; only installing the vLLM/CUDA wheels fails. --frozen is for not mutating the lock, not because a re-resolve would fail. Also note the uv-lock pre-commit hook runs locally. Signed-off-by: aviv ron <rona@il.ibm.com>

CI's coverage run executes only tests/unit/, which exercises just the pure-Python config module. Measuring the whole granite_switch package diluted the reported coverage to ~1%, because the hf/vllm/composer/ tutorials subpackages are GPU/model-only and unreachable in CI. Add [tool.coverage.run] omit rules for those subpackages so the CI coverage number reflects the code the unit suite is actually responsible for (now ~96%). Full-project coverage continues to be measured on the GPU cluster. Signed-off-by: aviv ron <rona@il.ibm.com>

Signed-off-by: aviv ron <rona@il.ibm.com>

njs2017 · 2026-07-15T19:43:05Z

PR Review

Strong infrastructure PR overall — the CI/CD direction looks good and the pre-commit/dev-experience improvements are valuable.

What looks good

Clear workflow split across CI, DCO, GPU tests, and publish
Good use of uv and caching
Nice contributor-experience improvements in CONTRIBUTING.md, CHANGELOG.md, and Makefile targets
README link fixes and .git-blame-ignore-revs are good cleanup

Requested changes

DCO sign-offs
The PR appears to include commits without DCO sign-off, so the DCO workflow will fail. Please re-sign the branch, e.g.:
```
git rebase --signoff origin/main
```
CI coverage gaps
tests/composer/ and tests/hf/ are excluded from CPU CI, and GPU tests are manual-only. Please document the intended coverage model clearly in the PR / docs so reviewers know which paths are protected automatically vs manually.
Custom hook maintenance
.pre-commit/validate_links.py adds a fair amount of custom validation logic. It would help to add at least basic tests for:
- ci/check_headers.py
- ci/add_signoff.py
- ci/check_dco.py
- ideally the link/import validator too

Nits

There is some purely cosmetic churn (newline-only changes like .github/CODEOWNERS, .gitignore)
A few workflow commands differ in their use of --frozen; worth making that consistent where possible

Overall: good direction, but I’d request the DCO fix and clearer CI/test-coverage expectations before merge.

antonpibm · 2026-07-20T08:38:20Z

+#   git config blame.ignoreRevsFile .git-blame-ignore-revs
+
+# Apply ruff format and lint autofixes across the codebase
+e1a92ceab87dc0ab6517916954a430d16b2da1b6


As we squash the commits this wouldn't work for the current PR, we can either (1) squash the commits as part of the changes so that there is a single commit in this PR, (2) after we merge this PR, open a new PR only for the blame ignore with the squash commit

@antonpibm In that case, I suggest we split this PR into two parts.
First - only the ruff formatting changes - this one needs to be ignored in git blame.
Second - after we merged the first, merge the CICD work - this should not get ignored by git blame since it is authentic development work, and not a reformat.
we can insert also the git blame ignore revs with the new sha after the first pr merge into the second pr.
Technically it is not complicated to aheieve since the reformat commit was the first commit in this branch, so I can easily split it into two.
If you agree, I will do it.

antonpibm

Please see the minor comments

….0 MVP - Shorten CLAUDE.md pre-commit section to a brief blurb pointing at the CI/CD reference doc - Rename docs/CICD_PLAN.md -> docs/CICD.md as the living reference; retitle and fix the reference in pyproject.toml - Change CHANGELOG 0.1.0 from Pre-release to MVP Signed-off-by: aviv ron <rona@il.ibm.com>

Fold the DCO / Signed-off-by requirement into GIT_WORKFLOW.md so the sign-off steps live alongside the branching and commit guidance, with a pointer to CICD.md for the full hook and CI setup. Signed-off-by: aviv ron <rona@il.ibm.com>

aviv1ron1 added 11 commits July 9, 2026 15:22

Apply ruff format and lint autofixes across the codebase

e1a92ce

Signed-off-by: aviv ron <rona@il.ibm.com>

Add CI/CD: pre-commit hooks, GitHub Actions, and blocking ruff gate

24f1bad

Signed-off-by: aviv ron <rona@il.ibm.com>

Point .git-blame-ignore-revs at the reformat commit

5c27167

Signed-off-by: aviv ron <rona@il.ibm.com>

improve documentation for DCO, add auto sign off hook

5409437

Signed-off-by: aviv ron <rona@il.ibm.com>

fix tests to run on github actions

384d5b2

Signed-off-by: aviv ron <rona@il.ibm.com>

remove uv from pre commit execution documentation

c07d4c9

Signed-off-by: aviv ron <rona@il.ibm.com>

fix pre commit order

584437b

Signed-off-by: aviv ron <rona@il.ibm.com>

run pre commit hooks as post commit validations

6ac9465

Signed-off-by: aviv ron <rona@il.ibm.com>

update plan

d589514

Signed-off-by: aviv ron <rona@il.ibm.com>

remove composer tests from ci

28acc8b

Signed-off-by: aviv ron <rona@il.ibm.com>

remove hf tests

991c35d

Signed-off-by: aviv ron <rona@il.ibm.com>

aviv1ron1 added 14 commits July 9, 2026 21:39

remove hf tests from ci

1fc4cda

Signed-off-by: aviv ron <rona@il.ibm.com>

remove hf tests from ci

4103aec

Signed-off-by: aviv ron <rona@il.ibm.com>

Harden validate_links against malformed pyproject.toml

ea864f7

Signed-off-by: aviv ron <rona@il.ibm.com>

Document whole-tree CI enforcement for large-file and merge-conflict …

3bbb162

…hooks Signed-off-by: aviv ron <rona@il.ibm.com>

Document CPU-only local setup for macOS/no-GPU in CONTRIBUTING

630440d

Signed-off-by: aviv ron <rona@il.ibm.com>

update cicd plan

68ed984

Signed-off-by: aviv ron <rona@il.ibm.com>

turn images into non relative urls, so they show up on pypi

aac20b8

Signed-off-by: aviv ron <rona@il.ibm.com>

reflect package version instead of hard coding a version

c9328b9

Signed-off-by: aviv ron <rona@il.ibm.com>

turn relative links into absolute so they work on pypi as well

2b1b638

Signed-off-by: aviv ron <rona@il.ibm.com>

aviv1ron1 marked this pull request as ready for review July 16, 2026 11:05

aviv1ron1 requested review from antonpibm and freunda as code owners July 16, 2026 11:05

aviv1ron1 requested a review from yairallouche as a code owner July 16, 2026 11:05

antonpibm reviewed Jul 20, 2026

View reviewed changes

Comment thread CLAUDE.md

antonpibm reviewed Jul 20, 2026

View reviewed changes

Comment thread docs/CICD_PLAN.md Outdated

antonpibm reviewed Jul 20, 2026

View reviewed changes

Comment thread CLAUDE.md

antonpibm reviewed Jul 20, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

antonpibm requested changes Jul 20, 2026

View reviewed changes

aviv1ron1 added 2 commits July 20, 2026 15:42

Add DCO sign-off guidance to git workflow doc

14a3e11

Fold the DCO / Signed-off-by requirement into GIT_WORKFLOW.md so the sign-off steps live alongside the branching and commit guidance, with a pointer to CICD.md for the full hook and CI setup. Signed-off-by: aviv ron <rona@il.ibm.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Cicd combined#95

Cicd combined#95
aviv1ron1 wants to merge 27 commits into
generative-computing:mainfrom
aviv1ron1:cicd-combined

aviv1ron1 commented Jul 9, 2026

Uh oh!

codecov-commenter commented Jul 9, 2026

Uh oh!

njs2017 commented Jul 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

antonpibm Jul 20, 2026

Uh oh!

aviv1ron1 Jul 20, 2026

Uh oh!

Uh oh!

antonpibm left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

aviv1ron1 commented Jul 9, 2026

Uh oh!

codecov-commenter commented Jul 9, 2026

Welcome to Codecov 🎉

Uh oh!

njs2017 commented Jul 15, 2026

PR Review

What looks good

Requested changes

Nits

Uh oh!

Uh oh!

Uh oh!

Uh oh!

antonpibm Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

aviv1ron1 Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

antonpibm left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants