feat(homepage): surface Ghost Keys in the For Supporters card - #113
Merged
Conversation
Ghost Keys were unreachable from the homepage. The nav Donate button goes to /donate/ (which links on to /ghostkey/ since #93), but nothing on the front page itself mentioned them. Adds the link without making the page busier, which was the constraint: the For Supporters card carried one link against two in each of its neighbours and had visible empty space below it. Filling that gap balances the row at two links per card, and the rendered page height is unchanged at 1944px. The existing second sentence ("Your support helps build decentralized internet infrastructure that matters") was generic filler, so it makes way for a concrete one that also explains the new link. Otherwise "Ghost Key" arrives as unexplained jargon on the front page. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CCLUFDUS75xXcRZ83yDzq1
Contributor
Author
|
Code-first review lens run (read the code before the description, looking for mismatches). No substantive findings. It independently verified every falsifiable claim:
Two non-blocking observations from the reviewer: stacked same-style links are the pre-existing pattern in the sibling cards rather than something new here, and link text is distinct so there's no ambiguous-link-name accessibility issue. The card's use of raw [AI-assisted - Claude] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Ghost Keys are unreachable from the homepage. The nav Donate button goes to
/donate/, which links on to/ghostkey/since #93, but nothing on the front page itself mentions them.The constraint when we discussed this was that the homepage is already arguably too busy, so the fix shouldn't add weight.
Approach
It doesn't add any. The For Supporters card carried one link against two in each of its neighbours, with visible empty space below it:
Filling that existing gap balances the row. Rendered page height is unchanged at 1944px on desktop.
The card's second sentence ("Your support helps build decentralized internet infrastructure that matters") was generic filler, so it makes way for a concrete one that also explains the new link. Without that, "Ghost Key" arrives as unexplained jargon on the front page.
Testing
hugobuild clean. Verified in Chromium at 1280 and 390 wide: exactly one/ghostkey/link on the page, desktop height unchanged at 1944px, and the three cards render evenly.Note on framing
We'd discussed a "membership" reframe and recurring billing, which would change this copy. Neither is built, so this describes what actually exists today: a one-time donation that issues a key. Worth revisiting the wording if the recurring model ever lands.
[AI-assisted - Claude]