[Deploy] Fast activity graph drawing - #5888
Draft
mstange wants to merge 14 commits into
Draft
Conversation
mstange
force-pushed
the
push-qlrqwlskoyom
branch
2 times, most recently
from
March 7, 2026 22:52
7edd29c to
6781a87
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5888 +/- ##
==========================================
+ Coverage 83.65% 83.69% +0.03%
==========================================
Files 348 349 +1
Lines 37339 37416 +77
Branches 10376 10500 +124
==========================================
+ Hits 31237 31314 +77
+ Misses 5674 5673 -1
- Partials 428 429 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mstange
force-pushed
the
push-qlrqwlskoyom
branch
2 times, most recently
from
March 9, 2026 15:02
7ae0cc9 to
6a88829
Compare
mstange
force-pushed
the
push-qlrqwlskoyom
branch
2 times, most recently
from
March 19, 2026 01:04
bc99e64 to
3672882
Compare
mstange
force-pushed
the
push-qlrqwlskoyom
branch
from
April 2, 2026 15:56
3672882 to
acbfa47
Compare
mstange
force-pushed
the
push-qlrqwlskoyom
branch
from
April 11, 2026 16:18
acbfa47 to
5f9873b
Compare
…ndex. Handle it during display instead.
mstange
force-pushed
the
push-qlrqwlskoyom
branch
from
July 28, 2026 18:38
5f9873b to
857bb1e
Compare
…dSelf" and "TotalButNotSelf" states. This will let us share work between the activity graph and the sidebar, see the next commit. There's unfortunately a bit of the clash between the variable names and the types now. Should we rename sampleSelectedStates to sampleRelationsToSelectedNode everywhere? It sounds a bit clunky.
Rename getSampleIndexToNonInvertedCallNodeIndexForFilteredThread to getSampleCallNodesForFilteredThread, and add getPreviewFilteredCtssSampleCallNodes / getPreviewFilteredCtssSampleSelectedStates so that the sidebar timings no longer have to recompute the selected states. The two profile-query call sites that computed a CallNodeSelfAndSummary now use getPreviewFilteredCtssSampleCallNodes rather than the filtered-thread array, since they index it with getPreviewFilteredCtssSamples. The two are only interchangeable while the summary strategy is 'timing' and there is no preview selection, which is true for every profile-query caller today, so this does not change any output.
mstange
force-pushed
the
push-qlrqwlskoyom
branch
from
July 28, 2026 18:54
857bb1e to
0cb2a80
Compare
Sadly this gives a big performance boost in Firefox.
…ons. When computing the activity graph fills, store the fractional sample positions as integers after multipyling by (1 << FIXED_PREC_BITS). This lets us use shifts and masking when we accumulate the contributions into the buffers in the hot loops.
mstange
force-pushed
the
push-qlrqwlskoyom
branch
from
July 28, 2026 20:26
0cb2a80 to
1082e5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production | Deploy preview
On my machine, when I press and hold the up/down keys on this profile, these changes reduce the time of each keydown event from 130ms to 23ms (~6x faster). https://share.firefox.dev/4d8gja7