chore: add @dcoric and @fabiovincenzi to MAINTAINERS.md and website - #1647
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
06kellyjac
left a comment
06kellyjac
left a comment
There was a problem hiding this comment.
LGTM
maybe merge after access is granted?
Also Denis's email is shorter, if that's correct we're all good. The only email I've seen for him on commits is a gmail.
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
|
@06kellyjac Thanks! We just agreed to set our emails to the ones we actually commit with for consistency. 👍🏼 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1647 +/- ##
==========================================
+ Coverage 90.32% 90.41% +0.09%
==========================================
Files 87 87
Lines 8661 8661
Branches 1603 1603
==========================================
+ Hits 7823 7831 +8
+ Misses 807 799 -8
Partials 31 31 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Oh, you don't have to use your commit emails, use whatever you'd be ok with receiving the odd email 🙂 I just wanted to check it was an actual email address 😅 Feel free to put them back to gr-oss domains if that's best, or don't totally up to you guys IMO |
kriswest
left a comment
kriswest
left a comment
There was a problem hiding this comment.
Technically this currently requires a vote of the maintainers to merge (and should merge before we ask @TheJuanAndOnly99 to apply the change). We should probably use this opportunity to update our governance to FINOS latest standard as the contributing doc mentions a voting process it doesn't define: https://git-proxy.finos.org/docs/development/contributing#governance
|
P.S. I fully support the appointments |
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
|
@kriswest Ready for merge! |
|
@TheJuanAndOnly99 could you update the git proxy maintainers team with our two new maintainers (Fabio and Denis) please. 2 down a few more to go soon we hope! |
|
Hi @kriswest happy to add them. Can you point me to a place where a vote was held or meeting minutes where there was consensus reached between the current maintainers? |
|
We had just completed the meeting but I have yet to minute. You should be able to see positive reviews or thumbs up from most of the existing maintainers (apart from @andypols who approved at the meeting and @grovesy who has been away/busy). Will that suffice. If not I'll ping you after I get minutes done in a few days (away at an off-site).
K
Sent from Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Juan Estrella ***@***.***>
Sent: Monday, 27 July 2026 18:47:01
To: finos/git-proxy ***@***.***>
Cc: West, Kristopher (Data & Engineering, Digital X) ***@***.***>; Mention ***@***.***>
Subject: Re: [finos/git-proxy] chore: add @dcoric and @fabiovincenzi to MAINTAINERS.md and website (PR #1647)
*********************************************
"This is an external email. Do you know who has sent it? Can you be sure that any links and attachments contained within it are safe? If in any doubt, use the Phishing Reporter Button in your Outlook client or forward the email to ~ I've Been Phished"
*********************************************
[https://avatars.githubusercontent.com/u/36825759?s=20&v=4]TheJuanAndOnly99 left a comment (finos/git-proxy#1647)<#1647 (comment)>
Hi @kriswest<https://github.com/kriswest> happy to add them. Can you point me to a place where a vote was held or meeting minutes where there was consensus reached between the current maintainers?
—
Reply to this email directly, view it on GitHub<#1647?email_source=notifications&email_token=AAM7PBEXQ6C5J4I55SLBTHL5G6IRLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBZGQ3TQMRUHA22M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5094782485>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAM7PBFCUEJUVM5O4OVQNM35G6IRLAVCNFSNUABFKJSXA33TNF2G64TZHMZDKNRVGEZTANZZHNEXG43VMU5TIOBZHAZDMMZSHAZKC5QC>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
National Westminster Bank plc. Registered in England No. 929027. Registered Office: 250 Bishopsgate, London EC2M 4AA. National Westminster Bank plc is authorised by the Prudential Regulation Authority, and regulated by the Financial Conduct Authority and the Prudential Regulation Authority.
The Royal Bank of Scotland plc. Registered in Scotland No. 83026. Registered Office: 36 St Andrew Square, Edinburgh EH2 2YB. The Royal Bank of Scotland plc is authorised by the Prudential Regulation Authority, and regulated by the Financial Conduct Authority and the Prudential Regulation Authority.
The Royal Bank of Scotland plc and National Westminster Bank plc are authorised to act as agent for each other.
The Royal Bank of Scotland plc and National Westminster Bank plc are UK chartered banks and are not chartered or licensed as banks by the United States or any individual state.
This e-mail message is confidential and for use by the addressee only. If the message is received by anyone other than the addressee, please return the message to the sender by replying to it and then delete the message from your computer. Internet e-mails are not necessarily secure. The Royal Bank of Scotland plc, National Westminster Bank plc or any affiliated entity (“NatWest” or “us”) does not accept responsibility for changes made to this message after it was sent. NatWest may monitor e-mails for business and operational purposes. By replying to this message you give your consent to the monitoring of your e-mail communications with us. Whilst all reasonable care has been taken to avoid the transmission of viruses, it is the responsibility of the recipient to ensure that the onward transmission, opening or use of this message and any attachments will not adversely affect its systems or data. No responsibility is accepted by NatWest in this regard and the recipient should carry out such virus and other checks as it considers appropriate.
|
|
@TheJuanAndOnly99 the AI summary may be enough, it's not ideal but shows we reviewed and agreed to merge: https://zoom-lfx.platform.linuxfoundation.org/meeting/95849833904-1785164400000/summaries?password=7c33f705-f6b3-48a3-87ca-095c84d34e0b We do t use these for.monutes as they aren't great TBH. I definitely have some feedback we could.pass.on to the LFX team. Including some better steering, previous meeting action items and GitHub IDs for participants makes a huge difference (when using a transcript and AI instead) |
|
Hi @kriswest maintainers have been added. Happy to pass along the feedback to the LFX team for the AI meeting minutes! |
|
Thanks! 🚀 |
4 participants
Description
Adds @dcoric and @fabiovincenzi to
MAINTAINERS.mdand website.Related Issue
Relates to #1646
Checklist
General