fix(rust): F# exceptions, non-exhaustive matches and obj type tests - #4917
Merged
ncave merged 4 commits intoAug 30, 2026
Merged
Conversation
- makeRecord now supplies the synthetic __base__ value, so constructing an F# exception no longer crashes the compiler with "The lists had different lengths" - get_Message skips that base field, whose null innerException faulted at runtime - MatchFailureException is declared in the runtime library, the way the other targets already get it, so a non-exhaustive match compiles - try_downcast returns a value rather than a reference, so `:? string as s` binds an s that is usable where a string is expected
ncave
reviewed
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:? string as sbinds an s that is usable where a string is expected