fix: Allow private inline functions to call other private functions and values - #4915
Open
roboz0r wants to merge 2 commits into
Open
fix: Allow private inline functions to call other private functions and values#4915roboz0r wants to merge 2 commits into
roboz0r wants to merge 2 commits into
Conversation
Member
|
Looking at this PR, please don't merge it as it seems like there are holes in the implementations. |
Contributor
Author
|
Happy to take another look at this. I'm not very familiar with the codebase so I was partly trusting Claude to help me find the relevant functions to change, and the tests looked reasonable. Was there a specific gap you noticed or is it a wider structural issue? |
Use the predicate the code generators use to decide exports, so values hidden by a signature file are caught too, and key the expansion-time check on the inline function the body belongs to instead of on inline depth, so an escape is no longer reported once per call site on top of the precompile-time error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows a
private inlinefunction to call otherprivatefunctions and values in the same file.