[eas-cli] Improve non-interactive error for unconfigured projects - #4153
Conversation
3331566 to
b0e1b7e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4153 +/- ##
==========================================
+ Coverage 63.27% 63.28% +0.01%
==========================================
Files 1023 1024 +1
Lines 46690 46699 +9
Branches 9844 9848 +4
==========================================
+ Hits 29538 29547 +9
Misses 15698 15698
Partials 1454 1454 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
🤖 AI code reviewDecision: Approve Overall PR risk: Low. The change modifies existing behavior: it rewrites the error text at two "EAS project not configured" throw sites on the shared project-ID resolution path, and it stops a related log warning in non-interactive mode. The affected surface is small and bounded to error and warning text; no credential or secret value is added to the output. The most plausible risk is that CI scripts or docs matching the old error strings stop matching, but the reviewers found no remaining source or test reference to the old strings, and the related tests were updated. No correctness, security, or consistency findings were raised by any reviewer. No findings. This review is advisory — it never blocks a merge and never auto-approves. |
|
@williamgrosset - can you add a screenshot of the output to the PR description? it's always good to see what it actually looks like when rendered in the terminal |
|
@brentvatne Good call, I updated the indentation and line breaks so it matches our existing styles. I think it looks better now Before
After
|
|
can we fix the duplicated "EAS project not configured" message? |
|
✅ Thank you for adding the changelog entry! |




Why
The current error tells users to run
eas init, but that command needs interaction and fails under the same conditions that produced the error.How
Extract one builder,
getUnconfiguredProjectError, and call it from all three throw sites. Every path now lists both recovery commands with their required flags, plus the accounts the user can create projects in. Also suppress theEAS project not configured.log warning in non-interactive mode, since every error message now states it.Test Plan
Updated the existing tests to assert the message on each path. Added a test showing that a single-account actor in non-interactive mode reaches the project fetch, which is where its error now comes from.
Manually verified with a local build running
project:info --non-interactive: