Fix weak email validation in Vaadin custom validator example#19263
Open
simpanda01 wants to merge 1 commit into
Open
Fix weak email validation in Vaadin custom validator example#19263simpanda01 wants to merge 1 commit into
simpanda01 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16682
The custom email validator in
FormView.java'saddCustomValidationExample()only checkedemail.contains("@"), which incorrectly passes invalid strings like"@"or"abc@"as valid emails.This PR replaces it with a proper regex-based check, consistent with the phone number validator already used in the same method.