fix(cad): parse whole s-expression blocks, and ship a board to run them on

[Kartikey1306]

tools/cad_pipeline.py extracts its blocks with non-greedy regexes:

re.search(r'\(eos_cpu(.*?)\)', content, re.DOTALL)
re.finditer(r'\(eos_peripheral(.*?)\)', content, re.DOTALL)

(.*?)\) stops at the first ). In

(eos_cpu
  (arch "aarch64")
  (core "cortex-a57")

that is the paren closing (arch ...) — so the match ends after the block's first attribute, and every later one falls outside it and silently takes its dataclass default.

What that looks like

file:   core=cortex-a72  freq=1800  fpu=crypto-neon  entry=my_entry
parsed: {"arch": "aarch64", "core": "cortex-a57", "freq_mhz": 1000}   ← the defaults

Every eos_peripheral comes back as unknown / unknown / 0x0 / irq -1 regardless of what the file says. And the region and peripheral counts are correct, so nothing looks wrong.

Those values flow straight into the generated artifacts:

• the DTS emits compatible = "unknown" and reg = <0x0 0x00000000> for every device
• the CMake toolchain emits -mcpu= for the wrong core

A linker script and device tree describing hardware that is not the board is worse than a failure, because it builds.

_sexpr_body() replaces both regexes with a depth counter that skips quoted strings, so a block ends where it actually ends.

Why this was never caught

The pipeline has no test and no input in this repository. The only board it is ever pointed at is eFab/samples/eos_reference_board.kicad_pcb, and embeddedos-org/eFab does not exist:

$ gh api repos/embeddedos-org/eFab
{"message":"Not Found","status":"404"}

Both eos CI jobs that invoke this tool die at that checkout, so the tool had never run anywhere — not in CI, not locally.

samples/eos_reference_board.kicad_pcb gives it one: the five memory regions the eos simulation workflow asserts on (FLASH_NOR, RAM_LPDDR4, UART0_PL011, HEAP_REGION, OTA_SCRATCH), a full CPU block, and two peripherals. That also unblocks eos's CAD job, which can point at this instead of a repository that isn't there.

Tests

tests/unit/test_cad_pipeline.py — 7 tests covering the parse and the generated artifacts. Against the unfixed parser, three fail:

FAILED test_cpu_attributes_track_the_file_not_the_defaults
FAILED test_peripheral_fields_are_parsed
FAILED test_generated_artifacts_carry_the_board_values
  assert 'arm,pl011' in '... compatible = "unknown"; reg = <0x0 0x00000000> ...'

The decisive one is the second CPU test: a board whose every value differs from the defaults must not read back as the defaults. A test using only the sample's own values would pass against the broken parser, since the sample happens to match CpuDef's defaults.

Verification

pytest tests/	302 passed
pipeline on the sample	all 5 artifacts generated, non-empty

Stacked on #66 — on master the macOS leg still pins the retired macos-13 image, so a branch off master cannot get a green run at all.

🤖 Generated with Claude Code

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!