feat(cli): refuse packages that cannot resolve, and summarise what the build contained - #74
Merged
Merged
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
…e build contained
Two gaps against the MLP developer walk, which runs `ebuild add wifi` and then
expects a build that says what it contained.
`ebuild add` warned about an unknown package and added it anyway:
$ ebuild add wifi
[warn] No recipe found for 'wifi' — adding anyway.
[ok] Added wifi to build.yaml
That trades one clear error now for a confusing one at build time, in a file
the developer has since committed. It now refuses, and says what would help:
$ ebuild add wifi
[error] No recipe for 'wifi'.
Available: freertos, littlefs, lwip, mbedtls, zlib
To add it anyway: ebuild add wifi --force
$ ebuild add lwipp
[error] No recipe for 'lwipp'.
Did you mean: lwip?
`--force` keeps the old behaviour for anyone who genuinely wants an entry
ahead of its recipe, and says plainly that it will not resolve. Refusing
without an escape hatch would be the other kind of unhelpful.
The build then reports what it actually contained:
EmbeddedOS Build
OK toolchain arm-none-eabi-gcc
OK board configuration stm32f4
OK lwip
MISS mqtt declared, nothing resolved
OK temperature-monitor executable
The case worth having is MISS. A package that resolved to no include or
library directory contributed nothing, whatever build.yaml says -- the build
still succeeds, the feature is simply absent, and until now nothing said so.
The summary is rendered through the logger in the tests, so the assertions
are on what a developer actually sees rather than on an intermediate
structure.
271 tests pass, up from 255; 16 are new here.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
srpatcha
force-pushed
the
feat/add-refuses-and-build-summary
branch
from
August 29, 2026 22:42
dfdc429 to
253a2d4
Compare
This was referenced Aug 29, 2026
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two gaps against the MLP developer walk, which runs
ebuild add wifiand then expects a build that says what it contained.ebuild addadded packages it knew could not resolveThat trades one clear error now for a confusing one at build time, in a file the developer has since committed. It now refuses, and says what would help:
--forcekeeps the old behaviour for anyone who genuinely wants an entry ahead of its recipe, and says plainly that it will not resolve. Refusing with no escape hatch would be the other kind of unhelpful.This is not hypothetical — a forced
wifientry fails the build like this:Same information, one step later, after it is in a committed file.
A successful build did not say what was in it
MISSis the case worth having. A package that resolved to no include or library directory contributed nothing, whateverbuild.yamlsays. The build still succeeds, the feature is simply absent, and until now nothing said so.Verification
pytest: 271 passed, 16 new. The summary tests render through the real logger, so they assert on what a developer sees rather than on an intermediate structure. Walkedaddby hand for all three paths — known package, typo, unknown with and without--force.Stacks on #72 → #71 → #70.
mastercannot currently run its own suite.🤖 Generated with Claude Code