fix(mint): return errors for non-200 responses - #597
Open
arrangabriel wants to merge 1 commit into
Open
arrangabriel wants to merge 1 commit into
arrangabriel wants to merge 1 commit into
Conversation
Contributor
Author
|
That failing test is the same one that has been flaky before @sleipnir |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process_response({:status, ...})now emits anRPCErrorinto the stream when the status is not 200,instead of only recording it, with the same status and message as
GRPC.Client.Adapters.Gun.await/2.Mint delivers
:statusahead of:headersand:data, so the error is the first entry in the responselist: unary calls find it through
check_for_error/1before reachingKeyword.fetch!(responses, :ok), andstreaming calls find it as the first element of the stream. Both now return
{:error, %GRPC.RPCError{}}ratherthan raising.
The test injects a HEADERS frame carrying
:status: 502and asserts the error arrives ahead of the headersthat follow.
Fixes #596