Add missing pglite/static/excluded.pglite.exports - #88
Open
sriray wants to merge 1 commit into
Open
Conversation
src/backend/Makefile's pglite-exported-functions target cats this file, but it has never been committed to the repo. A clean checkout followed by build-pglite.sh fails immediately: cat: pglite/static/excluded.pglite.exports: No such file or directory Add it as an empty file, matching what its name implies (an exclusion list with nothing excluded by default) and what the sibling included.pglite.exports file establishes as the expected shape. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/backend/Makefile'spglite-exported-functionstarget does:but
pglite/static/excluded.pglite.exportshas never been committed to the repo (checked full history of that path — zero commits).build-pglite.shcalls this target directly (line ~149) with nothing upstream of it that creates the file, so a build from a clean checkout fails immediately:(the second miss there is just because this repro skips
./configure, which generatesexports.list; the first one is the actual bug.)Fix: add the missing file, empty, which is what an exclusion list with nothing excluded by default should be — the same shape as the sibling
included.pglite.exportsfile, just with no entries.Tested by re-running the exact
catinvocation from the Makefile target against a fresh clone with the file added; it now succeeds (exit 0) instead of failing on the first argument.No functional/behavioral change — this only unblocks the build step from erroring out before it can even start assembling the export list.