Skip to content

Add missing pglite/static/excluded.pglite.exports - #88

Open
sriray wants to merge 1 commit into
electric-sql:REL_18_3-pglitefrom
sriray:fix/missing-excluded-pglite-exports
Open

Add missing pglite/static/excluded.pglite.exports#88
sriray wants to merge 1 commit into
electric-sql:REL_18_3-pglitefrom
sriray:fix/missing-excluded-pglite-exports

Conversation

@sriray

@sriray sriray commented Aug 30, 2026

Copy link
Copy Markdown

src/backend/Makefile's pglite-exported-functions target does:

cat $(top_builddir)/pglite/static/excluded.pglite.exports \
$(top_builddir)/src/interfaces/libpq/exports.list \
...

but pglite/static/excluded.pglite.exports has never been committed to the repo (checked full history of that path — zero commits). build-pglite.sh calls this target directly (line ~149) with nothing upstream of it that creates the file, so a build from a clean checkout fails immediately:

$ git clone -b REL_18_3-pglite https://github.com/electric-sql/postgres-pglite
$ cd postgres-pglite
$ cat pglite/static/excluded.pglite.exports src/interfaces/libpq/exports.list
cat: pglite/static/excluded.pglite.exports: No such file or directory
cat: src/interfaces/libpq/exports.list: No such file or directory
$ echo $?
1

(the second miss there is just because this repro skips ./configure, which generates exports.list; the first one is the actual bug.)

Fix: add the missing file, empty, which is what an exclusion list with nothing excluded by default should be — the same shape as the sibling included.pglite.exports file, just with no entries.

Tested by re-running the exact cat invocation from the Makefile target against a fresh clone with the file added; it now succeeds (exit 0) instead of failing on the first argument.

No functional/behavioral change — this only unblocks the build step from erroring out before it can even start assembling the export list.

src/backend/Makefile's pglite-exported-functions target cats this
file, but it has never been committed to the repo. A clean checkout
followed by build-pglite.sh fails immediately:

  cat: pglite/static/excluded.pglite.exports: No such file or directory

Add it as an empty file, matching what its name implies (an
exclusion list with nothing excluded by default) and what the sibling
included.pglite.exports file establishes as the expected shape.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant