fix: prevent intra-process tempfile collisions in atomic store writes - #33
Merged
OndrejDrapalik merged 3 commits intoSep 7, 2026
Merged
Conversation
OndrejDrapalik
approved these changes
Sep 7, 2026
OndrejDrapalik
left a comment
OndrejDrapalik
left a comment
Collaborator
There was a problem hiding this comment.
The per-write tempfile fix is scoped correctly, and the added regression tests cover concurrent writes, record integrity and failed-rename cleanup. Fresh CI passed on Ubuntu/macOS with Node 22/24, plus the Rust and version checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent writeRecord calls in one Node process used the same temporary path, causing overwrites and rename failures. Give each write its own temporary filename and remove it when writing or renaming fails. Existing shallow-merge behavior is unchanged.
Regression tests exercise 100 concurrent writes to one key, verify the final record is complete, check that no temporary files remain, and cover cleanup after a failed rename. Both targeted tests pass.