Remove always-on DefaultInterfaceMemberConsumption language feature flag - #20442
Open
T-Gro wants to merge 2 commits into
Open
Remove always-on DefaultInterfaceMemberConsumption language feature flag#20442T-Gro wants to merge 2 commits into
T-Gro wants to merge 2 commits into
Conversation
Delete the dead LanguageFeature.DefaultInterfaceMemberConsumption enum case, its features-map entry and GetFeatureString arm. Collapse every language-version gate to its always-on path. Decouple the target-runtime DIM check from the enum via InfoReader.IsRuntimeSupportForDefaultImplementationsOfInterfaces and a checkRuntimeSupportForDefaultInterfaceMembersAndRecover helper; the FSComp string is retained as the display name for the runtime FS3351 diagnostic. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
T-Gro
added
the
NO_RELEASE_NOTES
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
…enerate xlf Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20152
LanguageFeature.DefaultInterfaceMemberConsumptionhas been enabled for every selectable--langversionsince F# 5.0, so the flag was dead configuration. The consumption gates now collapse to their enabled path, and the target-runtime check for default interface implementations (FS3351) is decoupled from the language-feature enum so the runtime diagnostic still fires.