Remove always-on DotlessFloat32Literal language feature flag - #20441
Open
T-Gro wants to merge 1 commit into
Open
Remove always-on DotlessFloat32Literal language feature flag#20441T-Gro wants to merge 1 commit into
T-Gro wants to merge 1 commit into
Conversation
The DotlessFloat32Literal feature shipped in F# 5.0. Since the minimum accepted --langversion is now 8.0, the flag is permanently enabled and is dead configuration. Remove the LanguageFeature case, its features-map entry, and GetFeatureString arm, and collapse the gated lexer rule into a single always-on ieee32 rule by folding the dotless-integer case into the ieee32 regex. Regenerated xlf localization files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
T-Gro
added
the
NO_RELEASE_NOTES
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20145
DotlessFloat32Literalshipped in F# 5.0 and is enabled for every selectable--langversion(minimum accepted is 8.0), so its feature flag can never be turned off. Removed the dead configuration and collapsed the guarded lexer rule to its always-on behaviour.--disableLanguageFeature:DotlessFloat32Literalis no longer a recognised feature name.