Skip to content

chore(Test): Revert #20308 precautionary serial testing #20343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bartelink wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −10
Open

chore(Test): Revert #20308 precautionary serial testing #20343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncModuleFunctions.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
// Copyright (c) Microsoft Corporation. All Rights Reserved. See License.txt in the project root for license information.

// Tests for camelCase functions in module Async

// Intentionally in same collection to help rule out potential flakiness due to concurrency re #20306
[<Xunit.Collection(nameof FSharp.Test.NotThreadSafeResourceCollection)>]
module FSharp.Core.UnitTests.Control.AsyncModuleFunctionsTests

open System
Expand Down
8 changes: 1 addition & 7 deletions tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncType.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,9 +800,7 @@ type AsyncType() =
Assert.True(asyncWaitImm a)
#endif

// Intentionally in same collection to help rule out potential flakiness due to concurrency re #20306
[<Collection(nameof FSharp.Test.NotThreadSafeResourceCollection)>]
module AsyncTaskLikeAwaitTests =
module AsyncAwaitTaskLikeTests =

// Minimal custom task-like type wrapping Task<'T>
type MyTask<'T>(inner: Task<'T>) =
Expand Down Expand Up @@ -904,8 +902,6 @@ module AsyncTaskLikeAwaitTests =
|> asyncWaitImm
Assert.Equal(42, result)

// Intentionally in same collection to help rule out potential flakiness due to concurrency re #20306
[<Collection(nameof FSharp.Test.NotThreadSafeResourceCollection)>]
module AsyncStartTaskImmediateTaskLikeTests =

[<Fact>]
Expand Down Expand Up @@ -946,8 +942,6 @@ module AsyncStartTaskImmediateTaskLikeTests =

Assert.Equal(cts.Token, capturedCt)

// Intentionally in same collection to help rule out potential flakiness due to concurrency re #20306
[<Collection(nameof FSharp.Test.NotThreadSafeResourceCollection)>]
module AsyncAwaitStackTraceTests =

open System.Runtime.CompilerServices
Expand Down
Loading