ci(dmr): sign/notarize via internal repo and publish a Homebrew cask#1008
ci(dmr): sign/notarize via internal repo and publish a Homebrew cask#1008doringeman wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the packaging documentation in packaging/README.md to describe a new two-step, multi-repository release and signing workflow for the dmr binary. It details how macOS and Windows binaries are signed and notarized via an internal repository before being published as a Homebrew cask, and updates the required repository secrets accordingly. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
model-runner is public and can't use Docker's private signing action, so release-dmr.yml now only builds the (unsigned) archives, creates the release, and publishes WinGet — then auto-triggers release-dmr.yml in the internal docker/inference-engine-llama.cpp repo (which holds the signing credentials) to sign+notarize the macOS/Windows binaries, re-upload them to this release, and open the Homebrew cask PR. - Drop the unsigned Homebrew *formula* publish (replaced by a signed *cask* generated from the internal repo). - Add a trigger-signing job that dispatches the internal workflow with the tag (needs DMR_SIGN_TRIGGER_TOKEN: Actions:write on the internal repo). - Update packaging/README to document the two-repo, two-step flow. Signed-off-by: Dorin Geman <dorin.geman@docker.com>
e7e7d72 to
ab34777
Compare
model-runner is public and can't use Docker's private signing action, so release-dmr.yml now only builds the (unsigned) archives, creates the release, and publishes WinGet — then auto-triggers release-dmr.yml in the internal docker/inference-engine-llama.cpp repo (which holds the signing credentials) to sign+notarize the macOS/Windows binaries, re-upload them to this release, and open the Homebrew cask PR.