feat(cketh): expose the sweeper address in MinterInfo - #11240
Open
gregorydemay wants to merge 2 commits into
Open
feat(cketh): expose the sweeper address in MinterInfo#11240gregorydemay wants to merge 2 commits into
gregorydemay wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Exposes the threshold-ECDSA-derived sweeper address through get_minter_info.
Changes:
- Adds optional
sweeper_addressto the Candid and Rust API. - Derives the address from stored public-key material.
- Tests unavailable and initialized states.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
rs/ethereum/cketh/test_utils/src/lib.rs |
Adds the expected test sweeper address. |
rs/ethereum/cketh/minter/tests/cketh.rs |
Tests ckETH minter-info responses. |
rs/ethereum/cketh/minter/tests/ckerc20.rs |
Tests ckERC20 minter-info responses. |
rs/ethereum/cketh/minter/src/state.rs |
Exposes sweeper-address derivation from state. |
rs/ethereum/cketh/minter/src/main.rs |
Returns the address from get_minter_info. |
rs/ethereum/cketh/minter/src/endpoints.rs |
Extends the Rust response type. |
rs/ethereum/cketh/minter/cketh_minter.did |
Extends the public Candid interface. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
✅ No security or compliance issues detected. Reviewed everything up to d49ba1a. Security Overview
Detected Code Changes
|
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minter derives a dedicated sweeper address from its master threshold-ECDSA public key, and that address' ETH balance is the prepaid gas available for sweeping funded deposit addresses. Until now that address was not observable from outside the canister, so there was no way to check how much sweep gas was left or to top it up.
get_minter_infonow returns it assweeper_address, alongside the existingminter_address. Likeminter_address, it isnulluntil the minter has fetched its public key.🤖 Generated with Claude Code