chore: Add some HTTP outcalls metrics - #11233
Open
eichhorl wants to merge 5 commits into
Open
Conversation
|
✅ No security or compliance issues detected. Reviewed everything up to cdc1354. Security Overview
Detected Code Changes
|
pierugo-dfinity
approved these changes
Aug 20, 2026
alin-at-dfinity
approved these changes
Aug 20, 2026
Comment on lines
+54
to
+58
| pool_manager_metrics: metrics_registry.int_counter_vec( | ||
| "canister_http_pool_manager_metrics", | ||
| "Canister http pool manager related metrics, by kind.", | ||
| &[LABEL_TYPE], | ||
| ), |
Contributor
There was a problem hiding this comment.
Nit: The doc comment on the field ("Notable, but expected events observed by the pool manager, by kind") actually suggests a better name:
Suggested change
| pool_manager_metrics: metrics_registry.int_counter_vec( | |
| "canister_http_pool_manager_metrics", | |
| "Canister http pool manager related metrics, by kind.", | |
| &[LABEL_TYPE], | |
| ), | |
| pool_manager_events: metrics_registry.int_counter_vec( | |
| "canister_http_pool_manager_events", | |
| "Notable, but expected events observed by the pool manager, by kind.", | |
| &[LABEL_TYPE], | |
| ), |
As is, "metrics" is exceedingly vague. Everything is a metric, around here and in Prometheus.
| } | ||
|
|
||
| /// Records a notable, but expected event of the given kind. | ||
| pub(crate) fn pool_manager_metrics_inc(&self, label: &str) { |
Contributor
There was a problem hiding this comment.
observe_pool_manager_event?
| } | ||
|
|
||
| /// Records a failed operation of the given kind. | ||
| pub(crate) fn pool_manager_errors_inc(&self, label: &str) { |
Contributor
There was a problem hiding this comment.
observe_pool_manager_error?
You could also merge the two IntCounterVecs into one by adding an error="true|false" label. Not sure whether that makes sense in this specific context, but it's an option.
Contributor
Author
There was a problem hiding this comment.
Done: cdc1354, I kept both metric separate, which is more consistent with what other protocols do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some metrics and logs for HTTPS outcalls: