chore: Drop NetworkTopology::full_topology - #11216
Merged
Merged
Conversation
`NetworkTopology::full_topology` (only populated for the NNS subnet) holds the same subnets as `NetworkTopology::subnets` and the same routing table as `NetworkTopology::routing_table`. Stop populating it, so it can be dropped in a future release.
|
✅ No security or compliance issues detected. Reviewed everything up to 7d76ca5. Security Overview
Detected Code Changes
|
…ntical to the base topology on every single subnet, the behavior with or without full_topology is identical. And would be identical in case of a replica downgrade (it would simply fall back to the base topology instead of full_topology).
NetworkTopology::full_topologyNetworkTopology::full_topology
basvandijk
approved these changes
Aug 24, 2026
schneiderstefan
approved these changes
Aug 24, 2026
schneiderstefan
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but could you please do the RUN_ALL_BAZEL_TESTS thing, so that all upgrade downgrade tests have a chance to run?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkTopology::full_topology(only populated for the NNS subnet) holds the same subnets asNetworkTopology::subnetsand the same routing table asNetworkTopology::routing_table. Drop it altogether, as it is unused by all subnets but the NNS; and the NNS behaves identically with or without it (including in the case of a replica downgrade to a version that still populates it).