refactor: use record patterns for full-component access (S6878)#204
Merged
Conversation
Convert type-pattern bindings whose variable was used only to call every component accessor into record deconstruction patterns, e.g. case DType.Bool b -> ... b.nullable() case DType.Bool(var nullable) -> ... nullable Matches the existing idiom in SchemaCommand.formatDType and clears Sonar java:S6878. 26 sites across PredicateEvaluator, VortexWriter.serializeDType, VariantEncodingEncoder, MaskedEncodingEncoder, CascadingCompressor, VortexGridTui, JdbcImporter. Cases accessing only a subset (DType.Primitive->nullable in isMaskable, DType.Extension, Predicate.Between) are left as plain bindings so no unused component binding is introduced. Behavior-preserving; the Rust interop oracle confirms serializeDType stays byte-identical. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears SonarQube java:S6878 ("Use record pattern instead of explicit field access") — the rule fires when a type-pattern binding's variable is used only to call component accessors, covering every component.
Converts 26 such sites to record deconstruction, e.g.:
across
PredicateEvaluator,VortexWriter.serializeDType,VariantEncodingEncoder,MaskedEncodingEncoder,CascadingCompressor,VortexGridTui,JdbcImporter. Matches the idiom already used inSchemaCommand.formatDType.Cases that read only a subset of components are deliberately left as plain bindings so no unused component binding is introduced:
DType.Primitive → nullableinisMaskable,DType.Extension(unusednullable),Predicate.Between(passed whole).Correctness: record patterns bind positionally, so component order was verified against each record declaration by an independent review pass (
StructfieldNames/fieldTypes not transposed,Primitiveptype/nullable correct,NullableDataflow-scoping valid)../mvnw verifygreen including the Rust interop oracle, which guaranteesserializeDTypestays byte-identical on the wire.🤖 Generated with Claude Code