Skip to content

scope deploy event watcher to the exact release #130

Description

@atkrad

WatchDeployEvents keeps events whose involvedObject.name starts with <releaseName>-. That also matches sibling releases.

Watching shop-prod uses prefix shop-prod-, so a pod named shop-prod-canary-api-... from release shop-prod-canary shows up in the live deploy status and warnings.

The watcher should only show events for the release being deployed, including Deployments, ReplicaSets, Pods, Jobs, CronJobs, and Services.

Event objects usually do not carry the involved object's Deployah labels, so filtering Events by those labels may miss or need extra lookups. Pick the smallest exact-release filter. Leave internal/k8s as one package.

Test shop-prod and shop-prod-canary in the same namespace. While watching shop-prod, events from shop-prod-canary must not appear.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/cliCommands, flags, UX copyarea/k8sKubernetes client helpers, jobs, events, TLS, capabilitieskind/bugSomething is broken

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions