Keep Random-LTD sequence lengths above the configured minimum - #8529
Open
vineethsaivs wants to merge 2 commits into
Open
vineethsaivs wants to merge 2 commits into
vineethsaivs wants to merge 2 commits into
Conversation
Clamp to the first aligned sequence length at or above min_value, retaining the existing maximum bound. Signed-off-by: Vineeth Sai <vineethsai4444@gmail.com>
vineethsaivs
requested review from
loadams,
tjruwase and
tohtana
as code owners
September 15, 2026 17:59
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac0bde6cb0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Vineeth Sai <vineethsai4444@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Random-LTD rounds
min_value=8down to zero withseq_per_step=16, dropping every token from selected layers. Clamp to the first aligned length at or above the minimum.Test:
DS_ACCELERATOR=cpu PYTHONPATH=. python -m pytest tests/unit/runtime/test_data_efficiency.py -k random_ltd -q. Four CPU tests pass, including three DeepSpeedEngine SGD steps with actualRandomLayerTokenDropwrappers and assertions on both selected layers' input lengths.Apple M2 Pro CPU with one-rank Gloo exercises the 16-token retention boundary. The same test uses longer inputs on CUDA to exercise gather/scatter; that path was not run locally. Changed-file pre-commit passes.