docs: document PyTorch fused AdamW opt-in - #8512
Open
adenzhou1350 wants to merge 1 commit into
Open
adenzhou1350 wants to merge 1 commit into
adenzhou1350 wants to merge 1 commit into
Conversation
Signed-off-by: Xucheng Zhou <aden1350@outlook.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4db136cd32
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document how to select PyTorch's built-in fused AdamW through DeepSpeed configuration:
{ "optimizer": { "type": "AdamW", "params": { "torch_adam": true, "fused": true } } }The documentation explains that this avoids building DeepSpeed's native fused Adam extension and preserves PyTorch's compatibility, memory, and floating-point caveats. It does not change any runtime default.
Motivation and validation
On a Qwen3-4B-Base, sequence-2048, BF16, ZeRO-2 DP4 workload with four RTX 5090 GPUs, the existing opt-in reduced the measured optimizer-update phase from about 220 ms to 18.5 ms. Four order-balanced blocks measured a median whole-step speedup of
1.15845x, with a bootstrap 95% interval of[1.15329, 1.16659].Two reverse-order 20-step trajectories reproduced exactly within each optimizer arm and passed the repository's BF16 tolerance contract. These numbers motivate documenting the opt-in; they do not justify a global default or extrapolation to other optimizers, offload modes, models, runtimes, or hardware.
Applicable pre-commit hooks and
git diff --checkpass.