Skip to content

chore: pin archived haystack-experimental - #478

Merged
kacperlukawski merged 1 commit into
mainfrom
archive-haystack-experimental
Jul 29, 2026
Merged

chore: pin archived haystack-experimental#478
kacperlukawski merged 1 commit into
mainfrom
archive-haystack-experimental

Conversation

@julian-risch

Copy link
Copy Markdown
Member

Related Issues

Proposed Changes:

  • Tutorial 48 needs InMemoryChatMessageStore / ChatMessageRetriever / ChatMessageWriter, which were not adopted into Haystack core. Pin the final release (haystack-experimental==0.19.0.post1) in the install cell and in index.toml rather than removing the tutorial. Replace the beta notice with an archived notice, and repoint the component links from the API reference pages (being removed) to the tagged source.
  • guide_evaluation: drop the EvaluationHarness recommendation. It was discontinued in haystack-experimental 0.7.0 and the example notebook it linked no longer exists.

How did you test it?

Notebook JSON validated; index.toml validated as parseable TOML. Not executed (needs an OpenAI key).

Notes for the reviewer

  • Tutorial 47 needed no changes — fix: Update HITL tutorial to work with haystack 3.0 #475 already removed its experimental references.
  • Worth a second opinion: pinning leaves a recent, prominent tutorial depending on an archived package indefinitely. The alternative is retiring it or rewriting it against plain application-side chat history, which would remove the last user-facing dependency. Happy to do that instead.

`haystack-experimental` is archived; `0.19.0.post1` is its final release
and the `ChatMessageStore` components were not adopted into Haystack core.

Tutorial 48 genuinely needs those components, so pin the final release
rather than removing the tutorial. Replace the beta notice with an
archived notice and repoint the component links from the API reference
pages (being removed) to the tagged source.

guide_evaluation recommended `EvaluationHarness`, discontinued in
haystack-experimental 0.7.0, and linked an example notebook that no
longer exists. Drop the recommendation.

Tutorial 47 needed no changes — #475 already removed its experimental
references.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@julian-risch
julian-risch marked this pull request as ready for review July 28, 2026 15:34
@julian-risch
julian-risch requested a review from a team as a code owner July 28, 2026 15:34

@kacperlukawski kacperlukawski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we likely need to consider rewriting it.

@kacperlukawski
kacperlukawski merged commit ba5fdac into main Jul 29, 2026
3 of 7 checks passed
@kacperlukawski
kacperlukawski deleted the archive-haystack-experimental branch July 29, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants