fix(input): align canonical availability grammar - #7823
Open
Stardust0831 wants to merge 3 commits into
Open
Conversation
AsTonyshment
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #7783 and is related to #7822. It aligns the documented availability grammar with the canonical syntax enforced by the parser and setter. The public parser now rejects non-canonical spellings by comparing the input with the AST serializer output, the setter no longer duplicates that check, and the parser no longer accepts a comma as an alternative spelling of
and.The developer guide now states the exact spacing rules and gives explicit valid and invalid examples, including
mode in [a, b]versusmode in [a,b]. Tests cover non-canonical whitespace, list separators, redundant parentheses, and comma conjunctions.Verification: a strict local parser smoke test passed; the remote non-MPI, non-LCAO build completed successfully; and the full parameter registry generated
parameters.yamlsuccessfully. The dedicated GoogleTest target was not run because the build node could not download GoogleTest from GitHub.