dbeaver/pro#6505 adds min value for object property info - #4565
Merged
yagudin10 merged 7 commits intoAug 20, 2026
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
…r-zero-value-for-the-context-window-size
sergeyteleshev
requested review from
HocKu7,
SychevAndrey,
devnaumov,
dgr-dbeaver and
yagudin10
August 17, 2026 20:48
devnaumov
reviewed
Aug 18, 2026
| "Default property value" | ||
| defaultValue: Object | ||
| "Minimum allowed value for numeric properties" | ||
| minValue: Int @since(version: "26.2.0") |
Member
There was a problem hiding this comment.
I think it's better to add a new constraints field. Once we have more constraints, maxValue, minLength for text inputs, etc, the flat list will grow too large, so it's better to keep them all here.
type PropertyConstraints {
min: Float
max: Float
step: Float
minLength: Int
maxLength: Int
}
# в ObjectPropertyInfo:
constraints: PropertyConstraints @since(version: "26.2.0")
Contributor
Author
There was a problem hiding this comment.
i personally like the idea and wanted to do so from the start. but decided to start with simple implementation which is required right now. and maybe later extend it with something like you suggest. if backend team don't mind I would implement that
…r-zero-value-for-the-context-window-size
SychevAndrey
previously approved these changes
Aug 19, 2026
yagudin10
previously approved these changes
Aug 19, 2026
sergeyteleshev
dismissed stale reviews from yagudin10 and SychevAndrey
via
August 19, 2026 15:07
ff70ba2
yagudin10
approved these changes
Aug 19, 2026
HocKu7
approved these changes
Aug 19, 2026
…r-zero-value-for-the-context-window-size
…r-zero-value-for-the-context-window-size
yagudin10
deleted the
6505-cb-fix-the-ability-to-set-a-negative-or-zero-value-for-the-context-window-size
branch
August 20, 2026 11:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/dbeaver/pro/issues/6505