Tests - Unskip the three tests gated on $env:APPVEYOR - #10522
Open
andreasjordan wants to merge 1 commit into
Open
Tests - Unskip the three tests gated on $env:APPVEYOR#10522andreasjordan wants to merge 1 commit into
andreasjordan wants to merge 1 commit into
Conversation
AppVeyor is gone, but tests\gha.shim.ps1 sets $env:APPVEYOR so the harness
scripts keep working. That left three skip conditions permanently true on the
Azure fleet, silently, against runners they were never assessed on:
- Get-DbaWindowsLog.Tests.ps1 (the whole IntegrationTests Describe)
- Enable-DbaFilestream.Tests.ps1 ("FileStream Level to 2")
- Add-DbaComputerCertificate.Tests.ps1 ("PFX certificate with chain")
All three pass against the lab, including the skipped parts. This removes the
gates so CI can say whether the original reasons still hold on the current
image. The recorded reasons are kept in place as comments rather than deleted,
so a re-skip can say what actually failed.
(do Get-DbaWindowsLog, Enable-DbaFilestream, Add-DbaComputerCertificate)
Member
|
shit wait, @claude why didn't the tests trigger for andreas? |
Member
|
ahh outage 🙄 |
Member
|
reinited and real failures unfortuantely |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10521.
AppVeyor the service is gone, but
tests/gha.shim.ps1sets$env:APPVEYORso the portedappveyor.*.ps1harness keeps working. A side effect: three skip conditions written for the old AppVeyor image are now permanently true on the Azure fleet, and have been silently skipping ever since the move — on runners the reasons were never assessed against.Get-DbaWindowsLog.Tests.ps1(wholeIntegrationTestsDescribe)Enable-DbaFilestream.Tests.ps1("FileStream Level to 2")Add-DbaComputerCertificate.Tests.ps1("PFX certificate with chain")Why these are worth re-checking rather than left alone
The
Get-DbaWindowsLogreason in particular looks likely to have expired. Its VMs now boot from a sysprepped golden image and start the instance on first boot, which writes exactly the SQL Server startup event the command parses — plusRepair-GhaSqlServerNamerestarts the engine when the image carries a stale@@SERVERNAME. That is a different situation from the old hosted image the comment describes.The other two are genuinely unknown. The filestream reason is a property of the instance, and nothing in
.github/runners/image-scripts/configures FILESTREAM either way. The certificate one never recorded a reason at all.Evidence so far
All three pass against a live lab (SQL03/SQL04), including the parts CI skips:
That establishes the tests are sound, not that the runners will satisfy them — the skips are environmental. This PR is how we find out: CI scopes tests from the changed files, so these three run on the real image.
If CI disagrees
The recorded reasons are kept as comments rather than deleted, so re-skipping is cheap. If one fails, please re-skip that one on a condition describing the actual missing precondition rather than on
$env:APPVEYOR— the point of this change is that gating on a dead CI provider hides which environments a test really needs.🤖 Generated with Claude Code