Upgrade mocha 10.8.2 → 11.7.6 (and ts-mocha to 11.1.0) - #1968
Merged
Conversation
*Why* Dependabot PR #1964 bumped mocha to 11.7.6 but the one-line package.json change fails CI. mocha is consumed via the `ts-mocha` wrapper, whose `^10.0.0` pin peer-caps mocha at `^10.X.X`, so the bump produces a peer-dependency conflict: YN0060: databricks provides mocha 11.7.6, which doesn't satisfy what ts-mocha requests CI installs with `yarn install --immutable` (unit-tests.yml, push.yml, create-build-artifacts.yml, release-pr.yml), so the stale/conflicting lockfile makes the install step fail outright. *What* - Bump `mocha` `^10.2.0` → `^11.7.6` (the Dependabot change). - Bump `ts-mocha` `^10.0.0` → `^11.1.0`, whose peer range now includes `^11.X.X`. ts-mocha 11 moved ts-node/tsconfig-paths to peers; the extension already declares `ts-node@^10.9.2` and tsconfig-paths is an optional peer, so no further additions are needed. - Regenerate yarn.lock. `@types/mocha@^10.0.6` is unchanged (10.0.10 is still `latest`; no v11 types line, API stable). `@wdio/mocha-framework` pulls its own `mocha@^10.3.0` as a direct dependency, so the e2e/wdio path is unaffected. mocha 11 requires node `^18.18 || ^20.9 || >=21.1`; the extension requires `node >=22.0`. Dev-only dependency: no runtime, extension-behavior, or shipped-output change. *Verification* - `yarn install --immutable` passes (no YN0028, no YN0060). - `yarn run build` (tsc --build) succeeds. - `test:integ:sdk` (ts-mocha --type-check, --dry-run) type-checks and loads all sdk-extensions *.integ.ts files and collects the suite. - `yarn run test:unit`: 268 passing, 0 failing (mocha 11 `new Mocha` harness in suite.ts). - eslint clean on suite.ts and the mocha-consuming test files. Supersedes #1964 (which cannot merge without the ts-mocha bump). Co-authored-by: Isaac
rugpanov
had a problem deploying
to
test-trigger-is
July 6, 2026 09:31 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Contributor
Author
|
🤖 Integration tests ❌ 7 of 35 test jobs failed for |
misha-db
approved these changes
Jul 6, 2026
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
rugpanov
had a problem deploying
to
test-trigger-is
July 6, 2026 11:28 — with
GitHub Actions
Failure
GitHub Actions
Failure
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dependabot #1964 bumped
mochato 11.7.6, but the one-linepackage.jsonchange fails CI. mocha is consumed via thets-mochawrapper, whose^10.0.0pin peer-caps mocha at^10.X.X, so the bump produces a peer-dependency conflict (reproduced locally by applying the PR verbatim):CI installs with
yarn install --immutable(unit-tests.yml,push.yml,create-build-artifacts.yml,release-pr.yml), so the stale/conflicting lockfile makes the install step fail outright — which is why #1964 is BLOCKED.What
mocha^10.2.0→^11.7.6(the Dependabot change).ts-mocha^10.0.0→^11.1.0(latest), whose peer range now includes^11.X.X.yarn.lock.Notes for the reviewer:
ts-node+tsconfig-pathsfrom direct deps to peers. The extension already declarests-node@^10.9.2(satisfies the peer) andtsconfig-pathsis an optional peer — so no additions are needed.@types/mocha@^10.0.6is unchanged:10.0.10is stilllatest(no v11 types line; the mocha type API is stable).@wdio/mocha-framework@9.29.0pulls its ownmocha@^10.3.0as a direct dependency, so the e2e/wdio path is unaffected and keeps mocha 10 internally.^18.18 || ^20.9 || >=21.1; the extension requiresnode >=22.0.Dev-only dependency — no runtime, extension-behavior, or shipped-output change for users.
Verification
yarn install --immutablepasses (noYN0028, noYN0060).yarn run build(tsc --build) succeeds.test:integ:sdk(ts-mocha --type-check,--dry-run) type-checks and loads allsrc/sdk-extensions/**/*.integ.tsfiles and collects the suite.yarn run test:unit: 268 passing, 0 failing (mocha 11new Mochaharness insuite.ts).eslintclean onsuite.tsand the mocha-consuming test files.Supersedes #1964 (which cannot merge without the
ts-mochabump).This pull request and its description were written by Isaac.
This PR was created with GitHub MCP.