test(kernel): add a non-blocking Reyden E2E leg to the nightly - #425
Merged
Conversation
mani-mathur-arch
marked this pull request as ready for review
July 24, 2026 08:12
mani-mathur-arch
force-pushed
the
mani/kernel-reyden-e2e
branch
from
July 24, 2026 08:44
b83f4e0 to
1eaac81
Compare
Reruns the existing TestKernelE2E* funcs against the Reyden SEA reference engine (TEST_WAREHOUSE=reyden + DATABRICKS_REYDEN_HTTP_PATH), routed via kernelTestDBWith. The step is continue-on-error since Reyden can be down or diverge from dbsql, and reyden-only divergences self-skip via skipOnReyden. The reyden path comes solely from the TEST_REYDEN_WAREHOUSE_HTTP_PATH secret; with it unset the leg is inert and re-runs on the normal warehouse. Adds TestIsReydenLeg + TestSkipOnReyden: pure-env unit tests (no warehouse) for the leg selector (case-insensitive, path-gated, fail-safe when unset) and the skip gate, so the routing logic runs in the kernel unit-test job. Co-authored-by: Isaac Signed-off-by: Mani Kaustubh Mathur <mani.mathur@databricks.com>
mani-mathur-arch
force-pushed
the
mani/kernel-reyden-e2e
branch
from
July 27, 2026 20:05
1eaac81 to
94f2cd8
Compare
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
mani-mathur-arch
enabled auto-merge
July 28, 2026 17:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a non-blocking Reyden E2E leg to the nightly. Reyden is the SEA reference engine — the same SEA-via-kernel path as the existing kernel E2E suite, just pointed at a read-only reference warehouse over shared Unity Catalog. Rather than duplicate the 18
TestKernelE2E*funcs, this reuses them verbatim and routes the connection to Reyden when selected.kernel_reyden_e2e_test.go(new):isReydenLeg()(TEST_WAREHOUSE=reyden+ a reyden path inDATABRICKS_REYDEN_HTTP_PATH),reydenHTTPPath(), andskipOnReyden()— a gate for surfaces Reyden genuinely doesn't support. Inert unless the reyden env is set, so every existing run is unaffected.kernel_e2e_test.go:kernelTestDBWithroutesWithHTTPPathto the reyden warehouse on the reyden leg (same host + PAT). Thevariantdata-type subcase skips on reyden — it cannot decode VARIANT over inline Arrow (a reyden-side gap; dbsql-sea and Thrift read it fine). No DDL/DML in this suite, so nothing else needs gating.nightly-e2e.yml: a second, non-blocking (continue-on-error) run step in the existingkernel-e2ejob re-runs the kernel E2E funcs withTEST_WAREHOUSE=reyden— the kernel lib is already built, so it's just anothergo test. The Thrift-vs-kernel parity funcs are excluded (they compare the kernel against Thrift on one warehouse; meaningless cross-warehouse).Why
Give the SEA/kernel path continuous coverage against the Reyden reference engine, surfacing reyden-vs-dbsql divergences.
continue-on-errorbecause Reyden is a reference engine that can be down or diverge — a reyden-side failure must not fail the nightly (it surfaces in the step log). This mirrors the non-blocking Reyden integration leg in the shared driver-test suite.DATABRICKS_REYDEN_HTTP_PATHfalls back to the well-known reyden warehouse id on the same host when the secret is unset; if it andTEST_WAREHOUSEresolve empty, the suite simply runs against the normal warehouse (isReydenLeg()==false) — a harmless no-op.Testing
gofmtclean;go vetclean on the-tags databricks_kernelbuild.isReydenLeg, fail-safe when path unset, case-insensitive) and theskipOnReydengate unit-tested.