Conversation
Reject the terraform engine at selection time (bundle.engine and DATABRICKS_BUNDLE_ENGINE) with a message pointing at the direct engine or a CLI v1.17.x downgrade. Delete the terraform engine execution code (apply/plan/write/interpolate/import/unbind/install/init and tfdyn), keeping the terraform state-reading and name-mapping utilities still needed by migration and read-only commands. Simplify deploy/plan/destroy/bind/unbind to direct-only; a resolved terraform state now errors with guidance to run "bundle deployment migrate". Automatic in-place migration of terraform state is reintroduced separately. CI acceptance matrix is switched to the direct variant only. Co-authored-by: Isaac <no-reply@databricks.com>
…v1.18.x Co-authored-by: Isaac <no-reply@databricks.com>
Terraform, TerraformPlanPath, and TerraformPlanIsEmpty are no longer set or read after the engine removal. Co-authored-by: Isaac <no-reply@databricks.com>
Switch the engine matrix to direct only, delete the terraform-variant divergent golden files, remove the terraform/migration bootstrap tests (they deployed via the removed terraform engine; migration coverage returns with the in-memory migration), and regenerate out.test.toml. Co-authored-by: Isaac <no-reply@databricks.com>
… goldens Convert the per-test EnvMatrix overrides to direct only, delete the remaining terraform-only tests (lifecycle/select/unknown-field/direct-only error cases and terraform-specific config-remote-sync/telemetry paths), drop dead terraform EnvMatrixExclude entries, and regenerate all goldens. Add the changelog fragment. Co-authored-by: Isaac <no-reply@databricks.com>
…ructor Run go mod tidy (removes hashicorp/hc-install and terraform-exec, now only used by the separate codegen module) and trim their NOTICE entries plus the bundled terraform-binary entry. Remove the terraform test cell from the CI matrix and the unreachable deployplan.NewPlanTerraform. Co-authored-by: Isaac <no-reply@databricks.com>
…tion warning Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: e7429f8
Top 13 slowest tests (at least 2 minutes):
|
The engine variable no longer selects anything, so remove it as a test matrix dimension entirely: drop EnvMatrix/EnvRepl/EnvVaryOutput, rename all .direct. golden files to plain names, strip $DATABRICKS_BUNDLE_ENGINE from scripts and _script helpers, and update read_state.py/print_state.py/dbr_runner.py to stop branching on it. Delete the now-empty test.toml files, the EnvVaryOutput selftests, and the terraform-vs-direct permissions comparison test. Drop the engine cell from the CI envfilter. Restore direct_migration.go (reused by the pre-deploy migration, wired next). Co-authored-by: Isaac <no-reply@databricks.com>
When the resolved state uses the Terraform engine, convert it to a direct-engine state in memory (OpenMigratedTerraformState) and open the state DB with it before planning. The deploy's normal Finalize commits resources.json only if the WAL records changes; terraform.tfstate (local + remote) is backed up only then. Plan does not commit. Also fix whitespace flagged by the linter. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.