Skip to content

Validate app log sources before opening output files - #6133

Open
fallintoplace wants to merge 1 commit into
databricks:mainfrom
fallintoplace:fix/apps-logs-source-validation
Open

Validate app log sources before opening output files#6133
fallintoplace wants to merge 1 commit into
databricks:mainfrom
fallintoplace:fix/apps-logs-source-validation

Conversation

@fallintoplace

Copy link
Copy Markdown

Changes

  • validate --source before app lookup, token acquisition, and output-file creation
  • preserve existing output files when source validation fails
  • add command-level regression coverage

Why

apps logs opened --output-file with truncation before validating --source. A typo in the source filter could therefore erase an existing file even though the command immediately returned an argument error.

Tests

  • go test ./cmd/apps ./libs/apps/logstream

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

Based on git history, these people are best suited to review:

  • @jamesbroadhead -- recent work in cmd/apps/

Eligible reviewers: @MarioCadenas, @Shridhad, @atilafassina, @calvarjorge, @ditadi, @fjakobs, @igrekun, @keugenek, @pffigueiredo, @pkosiec

Suggestions based on git history. See OWNERS for ownership rules.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

An authorized user can trigger integration tests manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 6133
  • Commit SHA: 11175e5e8e41e40db4b2d2bf21cf098db481c1ae

Checks will be approved automatically on success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant