[VPEX][7/8] Add local-env acceptance tests#5833
Open
rugpanov wants to merge 1 commit into
Open
Conversation
Seventh in the stacked series. End-to-end acceptance coverage for "databricks local-env python sync" against the in-process fake server, which is where the command's user-visible behavior (text + --json output, every error path) is exercised — cmd/localenv itself carries no unit tests by design. Nine scenarios: help (three-level tree), no-target, flag-conflict, manager-unsupported (conda project), env-unsupported (404 -> E_ENV_UNSUPPORTED), json-error, serverless-check (dry-run plan), serverless-json (--json plan), and constraints-only. Scripts drive the hidden command by name; goldens were generated with -update and verified stable on a clean re-run. The --json "command" field and the managed pyproject marker both render as "local-env python sync". No source changes. Co-authored-by: Isaac
Contributor
Waiting for approvalCould not determine reviewers from git history. Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
Integration test reportCommit: 6c2fadc
23 interesting tests: 14 SKIP, 7 RECOVERED, 1 FAIL, 1 flaky
Top 5 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
PR 7 of 8 in the stacked
databricks local-env python syncseries (see #5823 for the full plan). Stacked on #5832 — review PRs 1–6 first; this PR's diff is onlyacceptance/localenv/(no Go source changes).This is the end-to-end acceptance coverage for the command, run against the in-process fake Databricks server. It's where the command's user-visible behavior (text +
--jsonoutput, and every error path) is exercised —cmd/localenv/itself carries no unit tests by design, per the repo convention that user-visible CLI output is covered by acceptance tests.Scenarios (9)
helplocal-env python/local-env python synchelp treeno-targetE_NO_TARGET(text)flag-conflict--cluster+--serverless→ Cobra mutual-exclusion errormanager-unsupportedenv-unsupportedE_ENV_UNSUPPORTEDat fetchjson-error--output jsonerror object (code/failurePhase)serverless-check--checkdry-run plan (text)serverless-json--check --output jsonplanconstraints-only--constraints-only --check --output jsonNotes
-updateand verified stable on a clean re-run.--jsoncommandfield and the managedpyproject.tomlmarker both render aslocal-env python sync.musterrguards the five expected-failure scenarios;traceshows the three output-producing ones.acceptance/localenv/.This pull request and its description were written by Isaac.
This PR was created with GitHub MCP.