Conversation
The generated CLI command files (cmd/workspace/**, cmd/account/**) and Terraform schema files (bundle/internal/tf/schema/**) carried lint findings that stayed hidden only because generated files are excluded from linting via generated: lax. This fixes them at their source in the generator templates, so the output is clean regardless of the exclusion. This does not touch the generated: lax exclusion. The remaining generated-file findings (staticcheck SA1019 on deprecated SDK methods, misspell on real SDK identifiers, dupword in SDK docstrings) are faithful reproductions of upstream spec/SDK content and are not fixable in this repo. Co-authored-by: Isaac
Collaborator
Integration test reportCommit: 70b95a7
23 interesting tests: 13 SKIP, 9 RECOVERED, 1 flaky
Top 6 slowest tests (at least 2 minutes):
|
janniklasrose
approved these changes
Jul 3, 2026
janniklasrose
left a comment
janniklasrose
left a comment
Contributor
There was a problem hiding this comment.
Do we want to enable linting for generated files but add an exception for the known violations? Otherwise, we won't catch regression for .tmpl changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated CLI command files (
cmd/workspace/**,cmd/account/**) and Terraform schema files (bundle/internal/tf/schema/**) carried lint findings that stayed hidden only because generated files are excluded from linting viagenerated: lax. This fixes them at their source in the generator templates, so the output is clean regardless of the exclusion.This does not touch the
generated: laxexclusion. The remaining generated-file findings (staticcheckSA1019 on deprecated SDK methods,misspellon real SDK identifiers,dupwordin SDK docstrings) are faithful reproductions of upstream spec/SDK content and are not fixable in this repo.This pull request and its description were written by Isaac.