feat: fall back to templates/dml and templates/schemas for generated specs - #151
Merged
Conversation
Shared SQL next to a template was never resolved. Generated specs now search spec-local dml first, then templates/dml; regular specs stay spec-local only.
Closed
1 task
Generated specs now search spec-local schemas first, then templates/schemas, matching sqlPath. Regular specs stay spec-local only.
rederik76
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_isTemplateGenerated, resolve relativesqlPathfrom the dataflow'sdml/directory first, thentemplates/dml/.schemaPathfrom the dataflow'sschemas/directory first, thentemplates/schemas/.templates/dml/ortemplates/schemas/.VERSIONtov0.24.0.Closes #150
Test plan
pytest tests/unit(387 passed, including sqlPath and schemaPath resolution cases)_sql150) — TERMINATED SUCCESS_sql150) — TERMINATED SUCCESS