Conversation
pederbe
marked this pull request as ready for review
September 10, 2026 06:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix cancelled subrequest finish losing Done
Summary
A cancelled legacy subrequest finish can mark the body complete while its terminal Done task is still waiting for channel capacity. Retrying finish then becomes a no-op and loses that task.
Reserve channel capacity before completing the body, then send Done synchronously. Preserve the existing premature-body and closed-channel error behavior. Add deterministic coverage for cancellation and retry, upgraded sessions, repeated and empty completion, and terminal errors.
Fixes #933.
Testing
cargo test --locked -p pingora-core --lib protocols::http::subrequest -- --nocapture: 85 passed.cargo test --locked -p pingora-core --lib: 591 passed, 2 ignored.cargo fmt --all -- --checkcargo check --locked --workspacecargo clippy --locked -p pingora-core --all-targets -- --allow=unknown-lints --deny=warnings