chore(test): refresh e2e fixtures - #405
Conversation
|
📝 WalkthroughWalkthroughThe pull request refreshes dependencies in multiple E2E fixtures. It updates framework runtimes, React and Vue type packages, build tools, and related development dependencies. It also changes generated fixture identifiers in Astro, Expo, React, and Vue metadata. Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/e2e/fixtures/astro/CLAUDE.md`:
- Line 1: Update the CLAUDE.md symlink target in the Astro fixture to use the
repository-relative AGENTS.md target (for example, ./AGENTS.md) instead of the
temporary /tmp path, ensuring the symlink resolves after checkout.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d998d1bf-3fef-44de-80ec-9247b00a8830
⛔ Files ignored due to path filters (12)
test/e2e/fixtures/astro/package-lock.jsonis excluded by!**/package-lock.jsontest/e2e/fixtures/expo/package-lock.jsonis excluded by!**/package-lock.jsontest/e2e/fixtures/express/package-lock.jsonis excluded by!**/package-lock.jsontest/e2e/fixtures/fastify/package-lock.jsonis excluded by!**/package-lock.jsontest/e2e/fixtures/nextjs-app-router-next14/package-lock.jsonis excluded by!**/package-lock.jsontest/e2e/fixtures/nextjs-app-router/package-lock.jsonis excluded by!**/package-lock.jsontest/e2e/fixtures/nextjs-pages-router/package-lock.jsonis excluded by!**/package-lock.jsontest/e2e/fixtures/nuxt/package-lock.jsonis excluded by!**/package-lock.jsontest/e2e/fixtures/react-router/package-lock.jsonis excluded by!**/package-lock.jsontest/e2e/fixtures/react/package-lock.jsonis excluded by!**/package-lock.jsontest/e2e/fixtures/tanstack-start/package-lock.jsonis excluded by!**/package-lock.jsontest/e2e/fixtures/vue/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (14)
test/e2e/fixtures/astro/CLAUDE.mdtest/e2e/fixtures/astro/package.jsontest/e2e/fixtures/expo/app.jsontest/e2e/fixtures/expo/package.jsontest/e2e/fixtures/fastify/package.jsontest/e2e/fixtures/nextjs-app-router/package.jsontest/e2e/fixtures/nextjs-pages-router/package.jsontest/e2e/fixtures/nuxt/package.jsontest/e2e/fixtures/react-router/package.jsontest/e2e/fixtures/react/index.htmltest/e2e/fixtures/react/package.jsontest/e2e/fixtures/tanstack-start/package.jsontest/e2e/fixtures/vue/index.htmltest/e2e/fixtures/vue/package.json
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
clerk/clerk_go(manual)clerk/dashboard(manual)clerk/accounts(manual)clerk/backoffice(manual)clerk/clerk(manual)clerk/clerk-docs(manual)clerk/cloudflare-workers(manual)
| @@ -1 +1 @@ | |||
| /tmp/clerk-fixture-astro-4ff1i6/AGENTS.md No newline at end of file | |||
| /tmp/clerk-fixture-astro-7nnvei/AGENTS.md No newline at end of file | |||
There was a problem hiding this comment.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
link='test/e2e/fixtures/astro/CLAUDE.md'
target=$(readlink "$link")
printf 'target: %s\n' "$target"
test -e "$link"Repository: clerk/cli
Length of output: 197
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf 'symlink entry:\n'
ls -l test/e2e/fixtures/astro/CLAUDE.md || true
printf '\nfixture astro directory:\n'
find test/e2e/fixtures/astro -maxdepth 2 -type f -o -type l -print | sort
printf '\nreferences to CLAUDE.md or AGENTS.md in e2e fixtures:\n'
rg -n "CLAUDE\.md|AGENTS\.md|clerk-fixture-astro" test/e2e/fixtures test/e2e -S || true
printf '\ngeneric references in repo:\n'
rg -n "clerk-fixture-astro|AGENTS\.md|/tmp/clerk" . -S --glob '!node_modules' --glob '!dist' --glob '!build' | head -200 || trueRepository: clerk/cli
Length of output: 2001
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf 'astro fixture files:\n'
find test/e2e/fixtures/astro -maxdepth 3 -type f | sort
printf '\nreadlink statuses for CLAUDE.md links:\n'
for link in test/e2e/fixtures/*/CLAUDE.md; do
printf '%s -> %s\n' "$link" "$(readlink "$link")"
if [ -e "$link" ]; then
printf ' resolve ok\n'
else
printf ' broken\n'
fi
done
printf '\nCLAUDE.md first lines:\n'
for f in test/e2e/fixtures/*/CLAUDE.md; do
printf '%s: ' "$f"
head -n 1 "$f" | cat -n
doneRepository: clerk/cli
Length of output: 1019
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf 'AGENTS.md files:\n'
find test/e2e/fixtures -maxdepth 2 -name 'AGENTS.md' -type f | sort
printf '\nastro AGENTS.md first lines:\n'
head -n 20 test/e2e/fixtures/astro/AGENTS.md || true
printf '\ncompare symlink target base name with existing file:\n'
python3 - <<'PY'
from pathlib import Path
link=Path('test/e2e/fixtures/astro/CLAUDE.md')
target=link.readlink()
print('link=', link)
print('target=', target)
print('exists=', target.exists())
print('relative_exists=', Path('test/e2e/fixtures/astro/AGENTS.md').exists())
print('same_basename=', Path(target).name == 'AGENTS.md')
PYRepository: clerk/cli
Length of output: 1258
Fix the CLAUDE.md symlink target.
test/e2e/fixtures/astro/CLAUDE.md points to /tmp/clerk-fixture-astro-7nnvei/AGENTS.md, a temporary path that does not exist in checkout. Use a repository-relative target such as ./AGENTS.md so the fixture remains usable after clone.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@test/e2e/fixtures/astro/CLAUDE.md` at line 1, Update the CLAUDE.md symlink
target in the Astro fixture to use the repository-relative AGENTS.md target (for
example, ./AGENTS.md) instead of the temporary /tmp path, ensuring the symlink
resolves after checkout.
Source: Learnings
Automated refresh of E2E test fixtures via the
refresh-fixturesworkflow.Generated by
bun run e2e:refresh-fixtures. Review the diff for anyunexpected framework changes (especially major version bumps in
upstream scaffolders) before merging.
Triggered by: schedule on refs/heads/main