fix(rpc): inspect first raw tx positional arg for replay protection - #382
Open
huklaa wants to merge 1 commit into
Open
fix(rpc): inspect first raw tx positional arg for replay protection#382huklaa wants to merge 1 commit into
huklaa wants to merge 1 commit into
Conversation
huklaa
requested review from
ZhiyuCircle,
ancazamfir,
romac and
sergio-mena
as code owners
September 11, 2026 20:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #381
Summary
Replay protection previously inspected only the parameter array shape for raw-transaction RPC methods, which allowed requests with additional positional parameters to bypass the intended raw transaction check.
This change makes the middleware consistently inspect the first positional argument as the raw transaction payload while preserving support for valid RPC requests that include additional parameters.
Changes
Testing
Added focused regression tests covering the extra-parameter case and the existing expected behavior.
Scope
The fix is intentionally limited to the replay-protection issue described in #381. A final duplicate/WIP check found no competing PR addressing the same behavior.