-
Notifications
You must be signed in to change notification settings - Fork 2
Add reservation benchmark #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jerbaroo
wants to merge
7
commits into
master
Choose a base branch
from
jerbaroo-benchmark
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e7c43e9
Add reservation benchmark
jerbaroo 12cf0cc
fixup! Add reservation benchmark
jerbaroo 97a6a33
fixup! Add reservation benchmark
jerbaroo 7642549
fixup! Add reservation benchmark
jerbaroo beb50e9
fixup! Add reservation benchmark
jerbaroo 984f3f3
fixup! Add reservation benchmark
jerbaroo 080f986
fixup! Add reservation benchmark
jerbaroo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,19 @@ | ||
| relative_dir_path="$(dirname "${BASH_SOURCE[0]}")" | ||
| absolute_dir_path="$(cd "$relative_dir_path" && pwd)" | ||
|
|
||
| python_version_hash=$(python --version --version | sha1sum | cut -c1-40) | ||
| venv_path="$absolute_dir_path/.venv-$python_version_hash" | ||
|
|
||
| # Then, we (create iff necessary) and activate an (empty!) virtual env | ||
| # so Maturin doesn't complain when running `maturin develop`. | ||
| if [ ! -d ".venv-$python_version_hash" ]; then | ||
| if [ ! -d "$venv_path" ]; then | ||
| echo "Creating an empty Python virtualenv to be able to run 'maturin develop', for Python version '$(python --version --version)' (hash $python_version_hash)..." | ||
| python -m venv ".venv-$python_version_hash" | ||
| python -m venv "$venv_path" | ||
| echo "Done!" | ||
| fi | ||
|
|
||
| source ".venv-$python_version_hash/bin/activate" | ||
| source "$venv_path/bin/activate" | ||
|
|
||
| # Ensure `pytest` is available in the venv; | ||
| # If we were to use `pytest` from Nix, it would not see the locally built python package! | ||
| uv pip install -r pyproject.toml --all-extras --quiet | ||
| uv pip install -r "$absolute_dir_path/pyproject.toml" --all-extras --quiet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.