Improve source map symbolication#1392
Draft
dannyhw wants to merge 2 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
4990cfb to
3223c4f
Compare
3223c4f to
fdf5f8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP based on patches received for resolving errors to editor paths etc, still needs extensive testing
Summary
/open-stack-framehandling by resolving macOS editor commands earlier and mapping feature-app source paths when possibleValidation
node_modules/.bin/biome check --write packages/dev-server/src/plugins/devtools/devtoolsPlugin.ts packages/dev-server/src/plugins/symbolicate/Symbolicator.ts packages/dev-server/src/plugins/symbolicate/sybmolicatePlugin.ts packages/repack/src/commands/rspack/start.tspackages/dev-server/node_modules/.bin/tsc --noEmit -p packages/dev-server/tsconfig.jsonpackages/repack/node_modules/.bin/tsc --noEmit -p packages/repack/tsconfig.jsongit diff --checkNote: the local pre-commit hook attempted to run pnpm through the bundled runtime and stopped before checks with a non-interactive modules purge prompt, so the commit was created after running the relevant checks directly.