[FEAT]: Add `team` command group by mcncl · Pull Request #727 · buildkite/cli

mcncl · 2026-03-29T23:22:32Z

Description

Adds support for group of team commands, as available in go-buildkite

Changes

adds team {create,delete,list,update,view}
adds tests for the new commands
updates main.go to support

❯ go run . team create Testers
{
  "id": "89cea5f7-a7c0-4183-b48c",
  "name": "Testers",
  "slug": "testers",
  "privacy": "visible",
  "default": false,
  "created_at": "2026-03-29T23:20:04.042Z",
  "created_by": {
    "id": "01831b25-7d66-431e-8dcf",
    "name": "Ben McNicholl",
    "email": "ben.mcnicholl@buildkite.com",
    "created_at": "2022-09-08T03:29:45.318Z"
  }
}

❯ go run . team list
[
  {
    "id": "3c911fd5-cf8f-4a45-814d",
    "name": "Everybody",
    "slug": "everybody",
    "description": "The default team",
    "privacy": "visible",
    "default": true,
    "created_at": "2026-03-16T02:08:21.763Z",
    "created_by": {
      "id": "01831b25-7d66-431e-8dcf",
      "name": "Ben McNicholl",
      "email": "ben.mcnicholl@buildkite.com",
      "created_at": "2022-09-08T03:29:45.318Z"
    }
  },
  {
    "id": "89cea5f7-a7c0-4183-b48c",
    "name": "Testers",
    "slug": "testers",
    "privacy": "visible",
    "default": false,
    "created_at": "2026-03-29T23:20:04.042Z",
    "created_by": {
      "id": "01831b25-7d66-431e-8dcf",
      "name": "Ben McNicholl",
      "email": "ben.mcnicholl@buildkite.com",
      "created_at": "2022-09-08T03:29:45.318Z"
    }
  }
]

❯ go run . team delete 89cea5f7-a7c0-4183-b48c --yes
Team deleted successfully.

Testing

Tests have run locally (with go test ./...)
Code is formatted (with go fmt ./...)

omehegan · 2026-03-31T01:19:10Z

+	var err error
+
+	spinErr := bkIO.SpinWhile(f, "Loading teams information", func() {
+		teams, _, err = f.RestAPIClient.Teams.List(ctx, f.Config.OrganizationSlug(), nil)


Any concerns about not paginating here? I'm not sure how many teams we return per page, but I'm guessing sooner or later we will come across someone who has hundreds of them.

omehegan · 2026-03-31T01:29:04Z

+		Description:               current.Description,
+		Privacy:                   current.Privacy,
+		IsDefaultTeam:             current.Default,
+		MembersCanCreatePipelines: false,


Claude flagged the fact that every time someone updates a team, it's going to set members_can_create_pipelines: false even if the current setting for that team is true. "Balderdash," said I. "Prove it!" So we looked at go_buildkite, where it turns out that the Team struct doesn't include all the fields that the API returns, including MembersCanCreatePipelines. And then looking upstream at the API in Team::Updater and how it would handle this, it looks like it would in fact apply the false flag and change the setting unexpectedly. We'd need to fix this in go_buildkite and then here do MembersCanCreatePipelines: current.MembersCanCreatePipelines,

If this makes sense to you, I can throw the PR at go_buildkite and then add a commit to this.

I think false is a sensible default? It's definitely safer than true and would still allow for creation of the team but with safeguards in place.

Discussed in Slack - we still need to fix go_buildkite to avoid us forcibly changing this setting when we update teams. That'll be a separate task.

buildsworth-bk-app

The latest merge from main left the branch unbuildable. I left three blockers for the parse, module, and callback-signature failures reported by CI, plus one non-blocking pagination edge case.

Want to dig deeper?

Paste this into your agent to explore the findings from this review's Buildkite build:

Download the buildsworth logs from build 8503, then answer my questions about the findings.

Install the reading-buildsworth-logs skill to run this.

About buildsworth

Model: gpt-5.6-sol with xhigh thinking.

How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.

Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. To let it approve, grant L2 approval by mentioning @buildsworth-bk (see L2 approval grant):

L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
L2 — Standard risk (new UI, additive API fields, refactors). Approved only with an L2 grant; otherwise comment-only.
L3 — High risk (auth, migrations, payments, secrets, perf-critical paths). Human review always required.

buildsworth-bk-app

The three build/compile blockers from the last pass are fixed. The pagination edge case is still open, and I left three non-blocking CLI edge cases inline.

Want to dig deeper?

Paste this into your agent to explore the findings from this review's Buildkite build:

Download the buildsworth logs from build 8563, then answer my questions about the findings.

Install the reading-buildsworth-logs skill to run this.

Previous concerns have been addressed.

buildsworth-bk-app

All prior buildsworth concerns are addressed in the current revision, and I found no new issues. This adds destructive and permission-changing team operations, so this remains comment-only.

Want to dig deeper?

Paste this into your agent to explore the findings from this review's Buildkite build:

Download the buildsworth logs from build 8582, then answer my questions about the findings.

Install the reading-buildsworth-logs skill to run this.

scadu · 2026-07-28T07:27:54Z

+
+		if len(all) > limit {
+			hasMore = true
+		}


Minor: Could we only set hasMore after confirming another result exists? When the total is exactly equal to --limit and the final page is full, this reports Showing 2+ teams even though page 2 is empty. Fetching one extra result or page would distinguish an exact boundary from truncated output. A test where the total equals both --limit and --per-page should cover it.

Stale review and Owen is on leave

buildsworth-bk-app

I left one non-blocking pagination validation edge case. The destructive and permission-changing team operations keep this comment-only.

Want to dig deeper?

Paste this into your agent to explore the findings from this review's Buildkite build:

Download the buildsworth logs from build 9503, then answer my questions about the findings.

Install the reading-buildsworth-logs skill to run this.

buildsworth-bk-app · 2026-07-29T04:29:57Z

+}
+
+func (c *ListCmd) Validate() error {
+	if c.PerPage < 1 {


Non-blocking: The REST API caps per_page at 100, but this accepts larger values. For example, with --per-page 101 --limit 200, the server returns 100 teams, listTeams treats that as a partial page, and stops after page 1 with hasMore == false. Could we reject values above 100 (or clamp the value) so pagination remains correct?

Still open — Validate continues to accept values above the API’s 100-item maximum, so the server-side cap can still make pagination stop after the first page.

Still open — Validate still accepts --per-page values above 100, so the server cap can make the first page look partial and stop pagination.

buildsworth-bk-app

The existing --per-page validation concern is still open; I found no new issues in this revision. The destructive and permission-changing team operations keep this comment-only.

Want to dig deeper?

Paste this into your agent to explore the findings from this review's Buildkite build:

Download the buildsworth logs from build 9513, then answer my questions about the findings.

Install the reading-buildsworth-logs skill to run this.

buildsworth-bk-app

One new team-permission blocker is inline, along with a non-blocking text-list gap. The existing --per-page validation concern remains open.

Want to dig deeper?

Paste this into your agent to explore the findings from this review's Buildkite build:

Download the buildsworth logs from build 9715, then answer my questions about the findings.

Install the reading-buildsworth-logs skill to run this.

buildsworth-bk-app · 2026-07-29T23:43:03Z

+		Privacy:                   c.Privacy,
+		IsDefaultTeam:             c.Default,
+		DefaultMemberRole:         c.DefaultMemberRole,
+		MembersCanCreatePipelines: c.MembersCanCreatePipelines,


Blocking: buildkite.CreateTeam serializes every permission boolean (none use omitempty), so omitting MembersCanCreateSuites and MembersCanCreateRegistries here sends both as false. The API defaults both to true for a minimal team, so bk team create silently disables those permissions. Could we expose or populate the remaining permission fields and cover the request body?

buildsworth-bk-app · 2026-07-29T23:43:03Z

+	}
+
+	return output.Table(
+		[]string{"Name", "Slug", "Privacy", "Default"},


Non-blocking: The other resource lists (cluster, queue) include the ID needed by their follow-up commands. This text table omits team.ID, while view, update, and delete accept only a team UUID, so a user cannot carry a listed row into those commands. Could we include an ID column?

mcncl requested review from a team as code owners March 29, 2026 23:22

omehegan previously requested changes Mar 31, 2026

View reviewed changes

mcncl added 2 commits April 1, 2026 12:01

chore: support pagination with teams list

e48679f

chore: allow teams list pagination

d4f894d

mcncl force-pushed the SUP-6704/team_commands branch from 341f59d to d4f894d Compare April 1, 2026 01:02

mcncl requested a review from omehegan April 1, 2026 02:11

omehegan mentioned this pull request Apr 7, 2026

Add missing fields to Team struct buildkite/go-buildkite#295

Merged

Merge branch 'main' into SUP-6704/team_commands

abf3c67

buildsworth-bk-app Bot previously requested changes Jul 27, 2026

View reviewed changes

Comment thread internal/team/view.go Outdated

Comment thread cmd/team/create.go Outdated

Comment thread main.go Outdated

Comment thread cmd/team/list.go

mcncl added 2 commits July 27, 2026 13:17

Merge remote-tracking branch 'origin/main' into SUP-6704/team_commands

6055150

fix(general): refactor code with new version shape

9fd2106

buildsworth-bk-app Bot reviewed Jul 27, 2026

View reviewed changes

Comment thread cmd/team/list.go

Comment thread cmd/team/update.go Outdated

Comment thread internal/team/view.go

chore(feedback): fix pagination edge cases

5e13e68

buildsworth-bk-app Bot reviewed Jul 27, 2026

View reviewed changes

scadu reviewed Jul 28, 2026

View reviewed changes

mcncl added 2 commits July 29, 2026 14:19

Merge remote-tracking branch 'origin/main' into SUP-6704/team_commands

fc370c7

fix(teams): hasMore only if more confirmed

9afeec1

buildsworth-bk-app Bot reviewed Jul 29, 2026

View reviewed changes

Merge branch 'main' into SUP-6704/team_commands

5291f82

buildsworth-bk-app Bot reviewed Jul 29, 2026

View reviewed changes

Merge branch 'main' into SUP-6704/team_commands

87a7153

buildsworth-bk-app Bot requested changes Jul 29, 2026

View reviewed changes

Uh oh!

Conversation

mcncl commented Mar 29, 2026

Description

Changes

Testing

Uh oh!

omehegan Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

omehegan Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

mcncl Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

omehegan Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

buildsworth-bk-app Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

buildsworth-bk-app Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

buildsworth-bk-app Bot left a comment

Choose a reason for hiding this comment

Uh oh!

scadu Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

buildsworth-bk-app Bot left a comment

Choose a reason for hiding this comment

Uh oh!

buildsworth-bk-app Bot Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

buildsworth-bk-app Bot Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

buildsworth-bk-app Bot Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

buildsworth-bk-app Bot left a comment

Choose a reason for hiding this comment

Uh oh!

buildsworth-bk-app Bot left a comment

Choose a reason for hiding this comment

Uh oh!

buildsworth-bk-app Bot Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

buildsworth-bk-app Bot Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants