Drop borgfs runtime warning about symlinks and improve corresponding docs#9859
Merged
ThomasWaldmann merged 2 commits intoJul 4, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.4-maint #9859 +/- ##
=============================================
- Coverage 82.06% 82.04% -0.03%
=============================================
Files 38 38
Lines 11383 11383
Branches 1794 1794
=============================================
- Hits 9342 9339 -3
- Misses 1459 1461 +2
- Partials 582 583 +1 ☔ View full report in Codecov by Harness. |
ThomasWaldmann
approved these changes
Jul 4, 2026
ThomasWaldmann
left a comment
ThomasWaldmann
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR - hopefully some people will read the docs and learn about nosymfollow and the dangers of mounted filesystems with symlinks in general.
| ``nosymfollow`` VFS mount option, for example: | ||
|
|
||
| borg mount <repo path> <mountpoint> | ||
| mount -o remount,nosymfollow <repo path> <mountpoint> |
| user=dir_user, group=dir_group, uid=dir_uid, gid=dir_gid) | ||
| self._create_filesystem() | ||
| llfuse.init(self, mountpoint, options) | ||
| logger.warning('Warning: The mounted archive is capable of containing symlinks that point outside the archive tree. When following such symlinks you may see files and directories within the mountpoint that do not reflect the archive content.') |
Member
There was a problem hiding this comment.
guess "mount also does not show such a warning" is the reason why "borg mount" should also not do that.
Member
|
Can you check master branch please and do a forward port? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning see #9254 (comment)