Move record id preparation into the JSON ingestion adapter - #1393
Merged
myronmarston merged 1 commit intoSep 20, 2026
Merged
Conversation
Collaborator
Author
|
This change is part of the following stack:
Change managed by git-spice. |
jwils
approved these changes
Sep 17, 2026
myronmarston
marked this pull request as ready for review
September 18, 2026 01:34
myronmarston
requested review from
BrianSigafoos-SQ,
bsorbo,
ellisandrews-toast,
jwondrusch,
marcdaniels-toast and
rossroberts-toast
as code owners
September 18, 2026 01:34
This was referenced Sep 18, 2026
myronmarston
added this pull request to stack #1399
September 18, 2026 18:43
myronmarston
force-pushed
the
myron/move-record-id-preparation-to-json-adapter
branch
from
September 18, 2026 19:31
7f9f74b to
bdf3b01
Compare
myronmarston
removed this pull request from stack #1399
September 18, 2026 19:44
myronmarston
changed the base branch from
main
to
myron/test-settings-ipv4-loopback
September 18, 2026 19:44
myronmarston
added this pull request to stack #1401
September 18, 2026 19:49
myronmarston
force-pushed
the
myron/move-record-id-preparation-to-json-adapter
branch
from
September 18, 2026 20:06
bdf3b01 to
d880756
Compare
myronmarston
force-pushed
the
myron/move-record-id-preparation-to-json-adapter
branch
2 times, most recently
from
September 18, 2026 23:46
d8c76ec to
f8d2c6b
Compare
- The indexer copied the envelope `id` into the record for every format. Only the JSON adapter knows that `record` is a Hash, so the copy belongs there. This removes the last format-specific `is_a?` check from the operation factory. - `ValidationResult` now carries the event to build operations from, so an adapter can return a prepared copy of the event. - Prepares for a typed `Event` whose `record` type is a per-format generic parameter. - Narrows `validation_result.record_preparer`/`.event` with `# : ...` type comments instead of `or raise`: both are always present together by construction once `failure` is nil, so the assertion can't fire. Generated with Claude Code
myronmarston
force-pushed
the
myron/move-record-id-preparation-to-json-adapter
branch
from
September 20, 2026 01:03
f8d2c6b to
2d4edee
Compare
myronmarston
deleted the
myron/move-record-id-preparation-to-json-adapter
branch
September 20, 2026 04:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The indexer copied the envelope `id` into the record for every ingestion format. Only the JSON adapter knows `record` is a Hash, so the copy moves there — this drops the last format-specific `is_a?` check from the operation factory and prepares for a typed `Event` whose `record` type is a per-format generic parameter.
🤖 Generated with Claude Code